Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to update lightspeed chatbot UI design for fixing AAP 32342 #1386

Merged
merged 11 commits into from
Nov 12, 2024
Merged

Conversation

justjais
Copy link
Contributor

@justjais justjais commented Nov 7, 2024

Jira Issue: https://issues.redhat.com/browse/AAP-32342

Description

PR to update lightspeed chatbot UI design for fixing AAP 32342

Testing

Steps to test

  1. Pull down the PR
  2. npm install
  3. npm start

Scenarios tested

NA

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

Copy link

# npm audit report

happy-dom  <15.10.2
Severity: critical
happy-dom allows for server side code to be executed by a <script> tag - https://github.com/advisories/GHSA-96g7-g7g9-jxw8
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/happy-dom

1 critical severity vulnerability

To address all issues (including breaking changes), run:
  npm audit fix --force

@justjais justjais changed the title [WIP DNM]PR to update lightspeed chatbot UI design for fixing AAP 32342 PR to update lightspeed chatbot UI design for fixing AAP 32342 Nov 12, 2024
@justjais justjais marked this pull request as ready for review November 12, 2024 11:07
Copy link
Contributor

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments. Others looked good. Pls take a look. Thanks!

@justjais justjais merged commit 64f8026 into main Nov 12, 2024
11 checks passed
@justjais justjais deleted the aap_32342 branch November 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants