Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose /generations/playbook to be consistent with roleGen #1465

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Dec 16, 2024

This way we have:

  • /api/v0/ai/generations/playbook for playbook generation
    and /api/v0/ai/generations/role for roles.

@goneri goneri force-pushed the goneri/expose-generations-playbook-to-be-consistent-with-roleGen_11325 branch 2 times, most recently from 7ad1417 to 8072274 Compare December 16, 2024 19:30
manstis
manstis previously approved these changes Dec 17, 2024
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

If I was being pedantic I'd suggest a test in test_views.py for the legacy URL.

@manstis
Copy link
Contributor

manstis commented Dec 17, 2024

This may help with the failing tests: #1466

@goneri goneri force-pushed the goneri/expose-generations-playbook-to-be-consistent-with-roleGen_11325 branch from 8072274 to 5c17164 Compare December 17, 2024 15:27
@manstis
Copy link
Contributor

manstis commented Dec 17, 2024

"More stable" != "Perfect".. I've kicked the tests off again.

@goneri goneri force-pushed the goneri/expose-generations-playbook-to-be-consistent-with-roleGen_11325 branch from 5c17164 to 34597fb Compare January 8, 2025 15:01
@goneri
Copy link
Contributor Author

goneri commented Jan 8, 2025

The CI problem is addressed by #1484

@goneri goneri force-pushed the goneri/expose-generations-playbook-to-be-consistent-with-roleGen_11325 branch from 34597fb to 035cb36 Compare January 8, 2025 16:33
This way we have:
- `/api/v0/ai/generations/playbook` for playbook generation
and `/api/v0/ai/generations/role` for roles.
@goneri goneri force-pushed the goneri/expose-generations-playbook-to-be-consistent-with-roleGen_11325 branch from 035cb36 to 7838728 Compare January 8, 2025 17:29
@goneri goneri requested a review from manstis January 8, 2025 17:53
@goneri goneri merged commit 48acf18 into main Jan 8, 2025
11 checks passed
@goneri goneri deleted the goneri/expose-generations-playbook-to-be-consistent-with-roleGen_11325 branch January 8, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants