schema1: set the new plan_ids keys #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests :D |
goneri
force-pushed
the
goneri/schema1-set-the-new-plan_ids-keys_3645
branch
from
9ba2b35 to
2dcda25
Compare
Amplitude cannot do a filter that match a single key in an array, if we want to correctly identify an event's plan(s) we need to flatten the plan_id keys.
goneri
force-pushed
the
goneri/schema1-set-the-new-plan_ids-keys_3645
branch
from
2dcda25 to
d7bca5c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amplitude cannot do a filter that match a single key in an array, if we want to
correctly identify an event's plan(s) we need to flatten the plan_id keys.