Add system_prompt to chat endpoint #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamiTakamiya
force-pushed
the
TamiTakamiya/AAP-38211/add-system-prompt-to-chat-api
branch
from
6ba1b6c to
425c9ef
Compare
TamiTakamiya
force-pushed
the
TamiTakamiya/AAP-38211/add-system-prompt-to-chat-api
branch
from
425c9ef to
939b6dd
Compare
|
justjais
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
changes LGTM, @TamiTakamiya can you please lemme know the use case for adding the debug only system prompt?
It is for letting Marty test various system prompts w/o setting up development environment 😃 |
TamiTakamiya
deleted the
TamiTakamiya/AAP-38211/add-system-prompt-to-chat-api
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: https://issues.redhat.com/browse/AAP-38211
Description
Add system_prompt to
POST /chatendpoint.Testing
Steps to test
Scenarios tested
Unit test cases are included.
Production deployment