Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat History Frontend-only Implementation #1489

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Chat History Frontend-only Implementation #1489

merged 1 commit into from
Jan 14, 2025

Conversation

TamiTakamiya
Copy link
Contributor

Jira Issue: https://issues.redhat.com/browse/AAP-38324

Description

Implement chat history UI.

Testing

Steps to test

  1. Pull down the PR
  2. Run unit tests

Scenarios tested

Unit tests + manual tests by running a local AI Connect server.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/AAP-38324/chat-history-frontend-only-implementation branch from 957d1b1 to 9a2d538 Compare January 13, 2025 13:26
@TamiTakamiya TamiTakamiya marked this pull request as ready for review January 13, 2025 13:50
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/AAP-38324/chat-history-frontend-only-implementation branch from 9a2d538 to 853fdf9 Compare January 13, 2025 17:26
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/AAP-38324/chat-history-frontend-only-implementation branch from 853fdf9 to 18957f0 Compare January 14, 2025 01:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

romartin
romartin approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@romartin romartin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looking good, thanks!!

Just one comment - the model selector does not change as with the conversation/tab, but I think that's only for debug mode, so on prod users will not see it, correct?

@TamiTakamiya
Copy link
Contributor Author

Just one comment - the model selector does not change as with the conversation/tab, but I think that's only for debug mode, so on prod users will not see it, correct?

Yes, that's correct.

@TamiTakamiya TamiTakamiya merged commit d9248bf into main Jan 14, 2025
11 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/AAP-38324/chat-history-frontend-only-implementation branch January 14, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romartin romartin romartin approved these changes

@jameswnl jameswnl Awaiting requested review from jameswnl

@justjais justjais Awaiting requested review from justjais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TamiTakamiya @romartin