feedback: allow events coming from roleGen #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
force-pushed
the
goneri/feedback-allow-events-coming-from-roleGen_31315
branch
from
0e1e490 to
2c9345f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
goneri
force-pushed
the
goneri/feedback-allow-events-coming-from-roleGen_31315
branch
2 times, most recently
from
5e3191f to
4396f22
Compare
goneri
force-pushed
the
goneri/feedback-allow-events-coming-from-roleGen_31315
branch
6 times, most recently
from
55c1d14 to
919fafe
Compare
manstis
reviewed
Jan 24, 2025
goneri
force-pushed
the
goneri/feedback-allow-events-coming-from-roleGen_31315
branch
3 times, most recently
from
753ec5d to
29cb634
Compare
mabashian
previously approved these changes
Jan 29, 2025
manstis
reviewed
Jan 30, 2025
| def test_feedback_generation(self): | ||
| action = { |
There was a problem hiding this comment.
I'm struggling to understand why the properties in this structure are duplicated.
If it's important that it's duplicated perhaps add a comment so somebody doesn't think to "clean it up" in the future.
Please explain yourself 😆
There was a problem hiding this comment.
Oops, it's me. Let's fix that.
Accept the action and feeback events coming from the extension for the role generation.
goneri
force-pushed
the
goneri/feedback-allow-events-coming-from-roleGen_31315
branch
from
29cb634 to
0dcac2a
Compare
|
goneri
deleted the
goneri/feedback-allow-events-coming-from-roleGen_31315
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept the action and feeback events coming from the extension for the role generation.