Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2025-24010: Update vite 5.4.6 to 5.4.14 #1508

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

TamiTakamiya
Copy link
Contributor

Jira Issue: https://issues.redhat.com/browse/AAP-38956

Description

Update vite 5.4.6 to 5.4.14 to address CVE-2025-24010

Testing

Steps to test

  1. Pull down the PR
  2. Run unit tests with npm run test in the ansible_ai_connect_chatbot sub-directory.
  3. ...

Scenarios tested

Unit tests.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

Copy link
Contributor

@mabulgu mabulgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍

@TamiTakamiya I don't usually review or approve draft PRs as they have a tendency to change. Do you work opposite? Request review of drafts?

@TamiTakamiya
Copy link
Contributor Author

@TamiTakamiya I don't usually review or approve draft PRs as they have a tendency to change. Do you work opposite? Request review of drafts?

I usually wait until all CI checks passed and move a draft PR to a regular one, then assign reviewers. But for this one, it is simple enough and I thought it would be better to send it for review considering the time difference between Europe and US.

Maybe I should have moved this to a regular PR. I just wanted to see the Konflux PR build completes successfully as it can fail for whatever reasons...

@TamiTakamiya TamiTakamiya marked this pull request as ready for review January 23, 2025 21:15
@TamiTakamiya TamiTakamiya merged commit 8b972d6 into main Jan 23, 2025
11 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/AAP-38956/upgrade-vite-version branch January 23, 2025 21:16
@mabulgu
Copy link
Contributor

mabulgu commented Jan 23, 2025

Normally I dont review the drafted PRs but I guess the status changed to draft while I was looking already, or maybe I missed it this time as this one was simple:) I normally wait for the checks to be passed but with this kinda small changes I leave the vallidation to the doer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants