AAP-20249: Admin Dashboard: [Feature flag] -M-A-G-I-C- Organizations

[manstis]

Jira Issue: https://issues.redhat.com/browse/AAP-20249

Description

This introduces a magic flag in LaunchDarkly for a (comma-separated) white-list of org_id's that circumvent all known checks for "Schema 2 Telemetry". i.e. if an org_id is present in LaunchDarkly then the "Schema 2 Telemetry" opt-in/out flag will be present in /me irrespective of other settings. Furthermore "Schema 2 Telemetry" events will be sent to Segment.

See #776 for details of local LaunchDarkly test support 🎉

Testing

1. settings.development.TELEMETRY_SCHEMA_2_ENABLED = True

Using the LaunchDarkly override settings detailed in #776 try with local settings for:

• "schema_2_telemetry_org_id_white_list": "1234567[*]" - Expect org_telemetry_opt_out: false to be present.
• "schema_2_telemetry_org_id_white_list": "" - Expect org_telemetry_opt_out to be missing.

For each, execute the api/v0/me endpoint and compare results with the expectations above.

1. settings.development.TELEMETRY_SCHEMA_2_ENABLED = False

Using the LaunchDarkly override settings detailed in #776 try with local settings for:

• "schema_2_telemetry_org_id_white_list": "1234567[*]" - Expect org_telemetry_opt_out: false to be present.
• "schema_2_telemetry_org_id_white_list": "" - Expect org_telemetry_opt_out to be missing.

For each, execute the api/v0/me endpoint and compare results with the expectations above.

[*] 1234567 is whatever org_id your local login belongs to.

Steps to test

1. Pull down the PR
2. make start-backends
3. make create-application
4. make run-server (or whatever you normally do)

Scenarios tested

See "Testing" above.

Production deployment

• [] This code change is ready for production on its own
• This code change requires the following considerations before going to production:

I renamed the system-wide environment variable to TELEMETRY_SCHEMA_2_ENABLED.

This needs to be reflected in Staging Secret Manager.

[romartin]

Hey @manstis

Just did a quick look and looks good, but just a small comment: could it be possible refactoring the name of this new flag from schema2 to analytics, WDYT? It is not a blocker at all anyway.

I mention because the schema2 is named everywhere in the code as analytics_telememtry. It's just for being consistent....

[manstis]

Hi @romartin

...could it be possible refactoring the name of this new flag from schema2 to analytics

To be honest, I renamed the flag in this PR from what it was in main as I thought it wasn't very clear.

The settings.TELEMETRY_SCHEMA_2_ENABLED flag is to be removed when this goes "live" so is short-lived.

Personally, I still prefer to include the version Schema name in the flag.. as we'll no doubt be getting other Schemas in the future.

[jameswnl]

the flag usage looks good to me. but I don't fully understand the overriding precedence and so I'll let Roger or others to review that.

[manstis]

Closing. The PR description and review discussion will distort review of latest changes.

I'll re-open as a new PR.

[manstis]

Replaced by #814