Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address security findings #875

Merged
merged 4 commits into from
Mar 26, 2024
Merged

address security findings #875

merged 4 commits into from
Mar 26, 2024

Conversation

gebhardtr
Copy link
Contributor

@gebhardtr gebhardtr commented Mar 14, 2024 •
edited
Loading

Address security findings:

  • python/Ssrf
  • javascript/InsecureHash

Jira Issue: https://issues.redhat.com/browse/AAP-20849

Description

Testing

Steps to test

  1. Pull down the PR
  2. ...
  3. ...

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@gebhardtr gebhardtr changed the title Address security findings: Address security findings Mar 14, 2024
@gebhardtr
Address security findings
4d0f706 
* javascript/InsecureHash

Signed-off-by: Richard Gebhardt <[email protected]>
@gebhardtr gebhardtr changed the title Address security findings address security findings Mar 15, 2024
@ansible ansible deleted a comment from github-actions bot Mar 15, 2024
@ansible ansible deleted a comment from github-actions bot Mar 15, 2024
@gebhardtr gebhardtr marked this pull request as ready for review March 15, 2024 23:31
jameswnl
jameswnl approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@jameswnl jameswnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have tests

@gebhardtr gebhardtr merged commit 89521a4 into main Mar 26, 2024
5 checks passed
@gebhardtr gebhardtr deleted the rg/snyk-fixes branch March 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneri goneri goneri approved these changes

@jameswnl jameswnl jameswnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gebhardtr @goneri @jameswnl