-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EE docs #18
Add EE docs #18
Conversation
dacd0bc
to
44a8719
Compare
@Andersson007 I pushed a commit directly to your branch to get the structure as agreed at the docs meeting. I also made a few edits and dropped the "terminology" section because I don't think it's that useful. TBH I found the terminology was a little confusing. Also I would assume people understand concepts like container runtimes and it's not the job of Ansible documentation to explain them. |
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Don Naro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@samccann could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
give a writer a second chance to look at a file, and she'll find more things to comment on :-)
docs/docsite/rst/getting_started_ee/build_execution_environment.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/getting_started_ee/build_execution_environment.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
…t.rst Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
@samccann all feedback is incorporated, PTAL |
Thanks. I'd like core approval first since this PR currrently adds the EE getting started guide to core docs as well. |
@sivel @nitzmahone PTAL #18 (comment) This PR's waiting for your approval to get merged |
@Andersson007 I added the orphan tag to suppress the toc-tree warning from sphinx. This is necessary if the index is not included in the main core index. My vote is still on publishing this on In a previous comment I mentioned a separate
|
I think y'all are waiting on me for this one. Thanks for removing this from the core docs. There's one other step to take. Basically, anything 'excluded' from core (and the japanese core translation) means you also need to add any new files to the exclude section in the conf.py files: Or those two docsets will no longer build :-) |
@samccann done, thanks, PTAL |
Discussed this one at the docs (DaWGs) meeting today (July 11, 2023). Agreement is to merge and keep this on the |
Thank you @Andersson007 Big +1 to all the work here. 🎉 🌮 🐙 |
thanks everyone for your great help! Would've been impossible this to look as good as it's now without you! |
This PR moves the files created in https://github.com/ansible/community-docs/pull/60/files.
Fixes ansible-community/community-team#243