Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro_inventory.rst to remove note on list/hash in inventory #1821

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

randomthingsandstuff
Copy link

Lists and hashes can be used in inventory files, particularly easily in YAML-based inventory files.

Lists and hashes can be used in inventory files, particularly easily in YAML-based inventory files.
@ansible-documentation-bot ansible-documentation-bot bot added the new_contributor This PR is the first contribution by a new community member. label Aug 31, 2024
@ansible-documentation-bot
Copy link
Contributor

Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

@oraNod oraNod requested a review from bcoca September 2, 2024 15:39
@bcoca
Copy link
Member

bcoca commented Sep 3, 2024

I believe this was a reference to the ini inventory that was used in most examples in the intro at the time, so I would still keep it but narrow it's scope to such inventory instead of removing it.

@randomthingsandstuff
Copy link
Author

I believe this was a reference to the ini inventory that was used in most examples in the intro at the time, so I would still keep it but narrow it's scope to such inventory instead of removing it.

I don't mind doing that at all, but I need to word this nicely, I think based on ease-of-use. The INI parser seem to have some support[0] for these structures because of the ast.literal_eval trick. But it appears ugly, because the INI parser does line-by-line, so any interesting/deep structures would be like one long line of ugly.

Not sure about its actual behavior (don't use it), but could you/others confirm that logic? Then, I can wordsmith it properly for followup review.

[0] (https://github.com/ansible/ansible/blob/e3ccdaaa2ef27b1de6db9e37b523677a605d5a5e/lib/ansible/plugins/inventory/ini.py#L346)

@oraNod
Copy link
Contributor

oraNod commented Sep 12, 2024

Hi @randomthingsandstuff We've made some changes to the underlying readthedocs project for this repository. I'm going to close and re-open this issue to kick off a new PR preview build.

You might notice there will be two checks for readthedocs. One for docs/readthedocs.org:stage-ansible-core and another for docs/readthedocs.org:ansible-core.

The stage-ansible-core check is for the old project and will result in a 404. Please ignore that and use the ansible-core check only.

Thank you for your patience and understanding. Also thanks for your contribution to the Ansible documentation. If you have any questions or concerns, please do let us know either here, in the docs channel on Matrix, or in the Ansible forum. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_contributor This PR is the first contribution by a new community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants