Add support for setting nodeps through cli and .ansible-lint #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dmitrij-zavrazhin-1304
requested review from
ssbarnea and
alisonlhart
and removed request for
a team
dmitrij-zavrazhin-1304
had a problem deploying
to
ack
GitHub Actions
Failure
|
ssbarnea
requested changes
Jul 31, 2024
| @@ -132,6 +132,11 @@ def initialize_options(arguments: list[str] | None = None) -> None | FileLock: | |||
| for k, v in new_options.__dict__.items(): | |||
| setattr(options, k, v) | |||
|
|
|||
| if options.nodeps is None or options.nodeps is False: | |||
There was a problem hiding this comment.
This is not how env vars are supposed to work. When defined, they should always override the config options.
Preference order should always be: cli > env > config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #4258, it seems that having an option to set nodeps using the command line interface and/or .ansible-lint file to be desireable, so here is a simple implementation of it.