fix pexpect child shutdown race #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzmahone
force-pushed
the
pexpect_data_loss
branch
from
ddc18e4 to
4c99282
Compare
* ensure that any stdout data produced by the child after the last `expect()` call is consumed * add regression test
nitzmahone
force-pushed
the
pexpect_data_loss
branch
from
4c99282 to
2df9632
Compare
Shrews
approved these changes
Dec 5, 2023
TheRealHaoLiu
pushed a commit
to TheRealHaoLiu/ansible-runner
that referenced
this pull request
Jan 16, 2024
* ensure that any stdout data produced by the child after the last `expect()` call is consumed * add regression test
TheRealHaoLiu
pushed a commit
to TheRealHaoLiu/ansible-runner
that referenced
this pull request
Jan 16, 2024
* ensure that any stdout data produced by the child after the last `expect()` call is consumed * add regression test
Shrews
pushed a commit
that referenced
this pull request
Feb 13, 2024
* ensure that any stdout data produced by the child after the last `expect()` call is consumed Co-authored-by: Matt Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1330
expect()call is consumed