Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ovirt source #12882

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix ovirt source #12882

merged 1 commit into from
May 31, 2023

Conversation

sll552
Copy link
Contributor

@sll552 sll552 commented Sep 14, 2022

SUMMARY

fixes #11056

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other

@AlexSCorey AlexSCorey self-assigned this Sep 21, 2022
@AlexSCorey
Copy link
Member

@sll552 Thanks for submitting this. In order to test it we have to be able to pull down your code. Currently it looks like the permissions on your fork of awx repo does not allow this action.

@sll552 sll552 force-pushed the fix_ovirt_inventory branch from 05d60b0 to 655286d Compare September 22, 2022 14:02
@github-actions github-actions bot added component:awx_collection issues related to the collection for controlling AWX component:ui labels Sep 22, 2022
@sll552 sll552 force-pushed the fix_ovirt_inventory branch from 655286d to 607cabf Compare September 22, 2022 14:04
@github-actions github-actions bot removed component:ui component:awx_collection issues related to the collection for controlling AWX labels Sep 22, 2022
@sll552 sll552 force-pushed the fix_ovirt_inventory branch from 607cabf to c066ffa Compare September 22, 2022 14:05
@sll552
Copy link
Contributor Author

sll552 commented Sep 22, 2022

Sorry I messed up the rebase (or more like the github sync button does 😄 )

Anyway I had a colleague of mine pull the code from my fork (git clone, git pull) which worked fine. Is that what you need to do? I also checked the settings and the fork is set to public and "Allow edits by maintainers" is also checked.

@AlexSCorey
Copy link
Member

AlexSCorey commented Sep 22, 2022 •
edited
Loading

oops my fault. I copied the ssh url wrong. I'm able to pull now.

@sll552
Copy link
Contributor Author

sll552 commented Oct 5, 2022

Have you had time to test? It would be nice for us to have this and remove our ugly workaround that breaks with every update 😉

@sll552
Copy link
Contributor Author

sll552 commented Jan 12, 2023

@AlexSCorey sorry to bother you, have you had the time to test it? This is currently a blocker for an update for us.

@john-westcott-iv john-westcott-iv added the community pull request Applied to community based pull requests for filtering label Jan 20, 2023
@sll552
Copy link
Contributor Author

sll552 commented Feb 16, 2023

Mind that with a current (latest) awx-ee container this won't work because the ovirt collection installation is broken since 21.12.0 version of the awx-ee. For testing this use 21.11.0 it works in my environment.

See ansible/awx-ee#179

@TheRealHaoLiu TheRealHaoLiu merged commit 444d054 into ansible:devel May 31, 2023
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
@sll552 @djyasin
Fix ovirt source (ansible#12882)
cd82c2d
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
@sll552 @djyasin
Fix ovirt source (ansible#12882)
0de8589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealHaoLiu TheRealHaoLiu TheRealHaoLiu approved these changes

Assignees

@AlexSCorey AlexSCorey

Labels
community pull request Applied to community based pull requests for filtering community component:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWX 19.0+ OVIRT Inventory Source Doesn't work
4 participants
@sll552 @AlexSCorey @TheRealHaoLiu @john-westcott-iv