-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Credential Input Source Export for Exporting Credentials using awxkit #14798
Open
neevnuv
wants to merge
19
commits into
ansible:devel
Choose a base branch
from
neevnuv:devel
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
801c2fd
Add CredentialInputSource
neevnuv f9d0dbe
Awxkit add credential input sources output for credentials (#1)
neevnuv 14f02f3
remove metadata from natural key (#2)
neevnuv be8d781
Remove NATURAL_KEY and change to dependant nonexport
neevnuv 597e9bf
adding credential_input_soucres
neevnuv 1828a00
add to credential_input EXPORTABLE_RESOURCES
neevnuv e1d3ff1
Remove unneccessery pass
neevnuv 6c1c33e
add HasCreate
neevnuv fe31c8f
Add CredentialInputSource
neevnuv 541ef8e
Awxkit add credential input sources output for credentials (#1)
neevnuv 172cd68
remove metadata from natural key (#2)
neevnuv 07054d0
Remove NATURAL_KEY and change to dependant nonexport
neevnuv 281e1d0
adding credential_input_soucres
neevnuv 74eacea
add to credential_input EXPORTABLE_RESOURCES
neevnuv 9a66920
Remove unneccessery pass
neevnuv ef861c6
add HasCreate
neevnuv 87895f6
Merge branch 'devel' of https://github.com/neevnuv/awx into devel
neevnuv 56b9806
fix linting
neevnuv 8ba47ef
Merge branch 'ansible:devel' into devel
neevnuv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably don't want this here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this allow to export the credential input sources when imoprting a credential with an input source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. As I explained before,
DEPENDENT_EXPORT
doesn't quite work with how this relationship is being exposed in the API. You'll have to leave this out, and in order to correctly export a user will need to do both--credentials
and--credential_input_sources
.