Email with custom notifications not working

[dmzoneill]

SUMMARY

This targets "Email with custom notifications not working"
related #13983

This checks for blank body and add templates errors for the user.

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• API

[jbradberry]

This is not going to work in the way that you expect.

In [1]: try:
   ...:     raise Exception("foo")
   ...: except Exception as e:
   ...:     msg = e
   ...:     msg += "bar"
   ...: 
---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
Input In [1], in <cell line: 1>()
      1 try:
----> 2     raise Exception("foo")
      3 except Exception as e:

Exception: foo

During handling of the above exception, another exception occurred:

TypeError                                 Traceback (most recent call last)
Input In [1], in <cell line: 1>()
      3 except Exception as e:
      4     msg = e
----> 5     msg += "bar"

TypeError: unsupported operand type(s) for +=: 'Exception' and 'str'

[jbradberry]

Also, using += to build up strings is an anti-pattern in Python. I'd instead suggest something like

msg = '\n'.join([
    str(e),
    ...whatever...
])

[TheRealHaoLiu]

what does # __str__ do?

[jbradberry]

Nothing.

[jbradberry]

The concept seems good, but the exception handling is broken as-is.