Websockets now use rest_framework configed auth #14855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Always support cookies, session, and also allow rest_framework configured auth methods over the browser websocket. * The node -> node websocket auth remains locked down and unchanged
chrismeyersfsu
force-pushed
the
aap-websocket_auth
branch
from
2ac1c46 to
0276a47
Compare
|
I can't approve this, but these changes worked for me when I tested it just now. |
chrismeyersfsu
requested review from
AlanCoding,
TheRealHaoLiu,
rooftopcellist,
relrod and
john-westcott-iv
dmzoneill
approved these changes
Feb 13, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
I'm not 100% sure what all auths this opens awx websockets to. I can say that this makes more auth systems work.