Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More locked down websocket path #14871

Merged
merged 1 commit into from
Feb 14, 2024
Merged

More locked down websocket path #14871

merged 1 commit into from
Feb 14, 2024

Conversation

chrismeyersfsu
Copy link
Member

SUMMARY
  • Previously, the nginx location would match on /foo/websocket... or /foo/api/websocket... Now, we require these two paths to start at the root i.e. /websocket/... /api/websocket/...
  • Note: We now also require an ending / and do NOT support /websocket_foobar but DO support /websocket/foobar. This was always the intended behavior. We want to keep /api/websocket/... "open" and routing to daphne in case we want to add more websocket urls in the future.
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
awx: 23.7.1.dev100+g5deac0d11b
ADDITIONAL INFORMATION

@chrismeyersfsu @dmzoneill
More locked down websocket path
b5b118d 
* Previously, the nginx location would match on /foo/websocket... or
  /foo/api/websocket... Now, we require these two paths to start at the
  root i.e. <host>/websocket/... /api/websocket/...
* Note: We now also require an ending / and do NOT support
  <host>/websocket_foobar but DO support <host>/websocket/foobar. This
  was always the intended behavior. We want to keep
  <host>/api/websocket/... "open" and routing to daphne in case we want
  to add more websocket urls in the future.
@dmzoneill dmzoneill merged commit f66cde5 into ansible:devel Feb 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmzoneill dmzoneill dmzoneill approved these changes

@AlanCoding AlanCoding Awaiting requested review from AlanCoding

@rooftopcellist rooftopcellist Awaiting requested review from rooftopcellist

@john-westcott-iv john-westcott-iv Awaiting requested review from john-westcott-iv

@TheRealHaoLiu TheRealHaoLiu Awaiting requested review from TheRealHaoLiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrismeyersfsu @dmzoneill