Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added troubleshooting and tips tricks content #15212

Merged
merged 15 commits into from
Jun 24, 2024
Merged

Conversation

tvo318
Copy link
Member

@tvo318 tvo318 commented May 21, 2024

SUMMARY

Resolves issue #15040 (troubleshooting section of UI) and #15192 (host alias)

Rendered chapter: https://ansible--15212.org.readthedocs.build/projects/awx/en/15212/administration/containers_instance_groups.html#customize-the-pod-spec

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Docs
AWX VERSION

latest

Adding host entries in execution environments
===============================================

In order to override DNS/host entries, add the following entries in the in the ``/etc/hosts`` file of the pod spec via the ``hostAliases`` attribute:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to override DNS/host entries, add the following entries in the in the ``/etc/hosts`` file of the pod spec via the ``hostAliases`` attribute:
In order to override DNS/host entries, add the following entries in the ``/etc/hosts`` file of the pod spec with the ``hostAliases`` attribute:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind I know zero about all of this, but I got the impression from the issue that the hostAliases entry was not in /etc/hosts but some podman file. I don't know if this meands hand-editing the ContainerFile produced by ansible-builder or some other file...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...okay a bit of poking in this troubleshooting page and I now think the entries go in the AWX spec file.. But again... I'm doing major guessing here.

@tvo318
Copy link
Member Author

tvo318 commented Jun 3, 2024

According to @fosterseth, we can add it like that to the container group pod spec so any job that is started with that pod spec with have /etc/hosts modified with that info.

@tvo318 tvo318 requested a review from samccann June 7, 2024 04:18
@@ -370,7 +385,7 @@ Container groups and instance groups are labeled accordingly.

.. note::

Despite the fact that customers have custom Pod specs, upgrades may be difficult if the default ``pod_spec`` changes. Most any manifest can be applied to any namespace, with the namespace specified separately, most likely you will only need to override the namespace. Similarly, pinning a default image for different releases of the platform to different versions of the default job runner container is tricky. If the default image is specified in the Pod spec, then upgrades do not pick up the new default changes are made to the default Pod spec.
Despite the fact that customers have custom pod specs, upgrades may be difficult if the default ``pod_spec`` changes. Most any manifest can be applied to any namespace, with the namespace specified separately, most likely you will only need to override the namespace. Similarly, pinning a default image for different releases of the platform to different versions of the default job runner container is tricky. If the default image is specified in the pod spec, then upgrades do not pick up the new default changes are made to the default pod spec.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Most any manifest can be applied to any namespace, with the namespace specified separately, most likely you will only need to override the namespace."

Should this say "Since any"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Despite the fact that customers have custom pod specs, upgrades may be difficult if the default pod_spec changes"

maybe,

"Note that using custom pod specs may cause issues on upgrade if the default pod spec changes"


The options available are:

- **Enable or Disable tmp dir cleanup**: choose whether you want to clean up the ``temp`` directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with AWX but the UI calls it the tmp dir, so should the text say tmp directory here as well?

@tvo318 tvo318 requested review from fosterseth and samccann June 14, 2024 00:34
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One litte nit suggested edit.

@@ -370,7 +382,7 @@ Container groups and instance groups are labeled accordingly.

.. note::

Despite the fact that customers have custom Pod specs, upgrades may be difficult if the default ``pod_spec`` changes. Most any manifest can be applied to any namespace, with the namespace specified separately, most likely you will only need to override the namespace. Similarly, pinning a default image for different releases of the platform to different versions of the default job runner container is tricky. If the default image is specified in the Pod spec, then upgrades do not pick up the new default changes are made to the default Pod spec.
Using a custom pod spec may cause issues on upgrades if the default ``pod_spec`` changes. Most any manifest can be applied to any namespace, with the namespace specified separately, most likely you will only need to override the namespace. Similarly, pinning a default image for different releases of the platform to different versions of the default job runner container is tricky. If the default image is specified in the pod spec, then upgrades do not pick up the new default changes that are made to the default pod spec.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most any manifest

is this supposed to say "Since any manifest"?

@tvo318 tvo318 merged commit 407194d into ansible:devel Jun 24, 2024
21 checks passed
@tvo318 tvo318 deleted the troubleshoot branch July 15, 2024 19:30
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
* Added troubleshooting and tips tricks content

* Added troubleshooting and tips tricks content

* Moved DNS host entry override info to customize pod spec section of CG chapter.

* Added troubleshooting and tips tricks content

* Moved DNS host entry override info to customize pod spec section of CG chapter.

* Update docs/docsite/rst/administration/containers_instance_groups.rst

Co-authored-by: Seth Foster <[email protected]>

* Update docs/docsite/rst/administration/containers_instance_groups.rst

Co-authored-by: Seth Foster <[email protected]>

* Update docs/docsite/rst/administration/containers_instance_groups.rst

Co-authored-by: Sandra McCann <[email protected]>

* Incorp'd review feedback from @fosterseth and @samccann

* Update docs/docsite/rst/administration/containers_instance_groups.rst

Co-authored-by: Sandra McCann <[email protected]>

* Final revisions based on @fosterseth's inputs.

---------

Co-authored-by: Seth Foster <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
* Added troubleshooting and tips tricks content

* Added troubleshooting and tips tricks content

* Moved DNS host entry override info to customize pod spec section of CG chapter.

* Added troubleshooting and tips tricks content

* Moved DNS host entry override info to customize pod spec section of CG chapter.

* Update docs/docsite/rst/administration/containers_instance_groups.rst

Co-authored-by: Seth Foster <[email protected]>

* Update docs/docsite/rst/administration/containers_instance_groups.rst

Co-authored-by: Seth Foster <[email protected]>

* Update docs/docsite/rst/administration/containers_instance_groups.rst

Co-authored-by: Sandra McCann <[email protected]>

* Incorp'd review feedback from @fosterseth and @samccann

* Update docs/docsite/rst/administration/containers_instance_groups.rst

Co-authored-by: Sandra McCann <[email protected]>

* Final revisions based on @fosterseth's inputs.

---------

Co-authored-by: Seth Foster <[email protected]>
Co-authored-by: Sandra McCann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants