Implement an option to choose a job type on relaunch (issue #14177)

[Sasa993]

SUMMARY

Supersedes #14837 - thought removing the issue ID from the feature branch would make the api-schema check in the workflow successful.

Fixes 14177 issue.
This PR adds a feature for users to change the Job Type (run type) on relaunching the job.

ISSUE TYPE

• New or Enhanced Feature

COMPONENT NAME

• API
• UI

AWX VERSION

23.6.1.dev334+ge2758724b1

ADDITIONAL INFORMATION

Before this change, modifying the run type required creating a new job, which could be inconvenient, especially for jobs with numerous prompts. The aim is to improve the user experience by allowing users to choose the run type while relaunching the job.

I decided to use a dropdown instead of modal (modal was suggested in the issue).
By implementing a dropdown instead of a modal, we avoid potential negative impacts on the user experience. The dropdown was chosen as it is already used for failed jobs, providing a consistent interface.

The drop-down menu with the options for the job type will only appear when the job is relaunched from the Job Details page (as agreed in the previous PR discussion)

[fosterseth]

thanks, this is a nice addition to the job relaunch feature

it would be nice to add a functional api test around this

• mock a job with job type check
• post to the api relaunch endpoint with job check run
• assert new job created with proper job type

take a look at some other tests have that creates/mocks job runs to get a good example to work with, and let me know if you need help with it

[Sasa993]

thanks, this is a nice addition to the job relaunch feature

it would be nice to add a functional api test around this

• mock a job with job type check
• post to the api relaunch endpoint with job check run
• assert new job created with proper job type

take a look at some other tests have that creates/mocks job runs to get a good example to work with, and let me know if you need help with it

Thank you. I have now added a working API test.

[fosterseth]

I'll also mention that we have a new UI that is going to replace the old UI eventually

You may wish to create a PR (or an issue) here as well once the api changes land https://github.com/ansible/ansible-ui

[Sasa993]

I'll also mention that we have a new UI that is going to replace the old UI eventually

You may wish to create a PR (or an issue) here as well once the api changes land https://github.com/ansible/ansible-ui

Yeah, I noticed that and it looks really good. Will do :)

[djyasin]

Hello @Sasa993! Thank you so much for making the requested changes. We have gone ahead and re-run CI checks. Would you mind rebasing this again when you have a chance?

[Sasa993]

Hello @Sasa993! Thank you so much for making the requested changes. We have gone ahead and re-run CI checks. Would you mind rebasing this again when you have a chance?

Done 😃
I can't figure out why api-schema keeps failing. Do you have any ideas?

[Sasa993]

Hi @fosterseth,
Any idea when this might be merged? I'd like to implement this on the new UI as well.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud