Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure bootstrap reqs are good #15733

Merged
merged 3 commits into from
Jan 13, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions awx/main/tests/functional/test_python_requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,37 @@
from django.conf import settings


def test_bootstrap_consistent():
with open('Makefile', 'r') as f:
mk_data = f.read()
bootstrap_reqs = None
for line in mk_data.split('\n'):
if line.startswith('VENV_BOOTSTRAP'):
parts = line.split()
bootstrap_reqs = parts[parts.index('?=') + 1 :]
break
else:
raise RuntimeError('Cound not find bootstrap line')

Check warning on line 18 in awx/main/tests/functional/test_python_requirements.py

View check run for this annotation

Codecov / codecov/patch

awx/main/tests/functional/test_python_requirements.py#L18

Added line #L18 was not covered by tests

req_data = None
with open('requirements/requirements.txt', 'r') as f:
req_data = f.read()

different_requirements = []
for req in bootstrap_reqs:
boot_req_name, _ = req.split('=', 1)
for line in req_data.split('\n'):
if '=' not in line:
continue
req_name, _ = line.split('=', 1)
if req_name == boot_req_name:
if req != line:
different_requirements.append((req, line))

Check warning on line 33 in awx/main/tests/functional/test_python_requirements.py

View check run for this annotation

Codecov / codecov/patch

awx/main/tests/functional/test_python_requirements.py#L33

Added line #L33 was not covered by tests
break

assert not different_requirements


@pytest.mark.skip(reason="This test needs some love")
def test_env_matches_requirements_txt():
from pip.operations import freeze
Expand Down
Loading