Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Ansible 11 redirects #265

Merged
merged 1 commit into from
Nov 21, 2024
Merged

update Ansible 11 redirects #265

merged 1 commit into from
Nov 21, 2024

Conversation

samccann
Copy link
Collaborator

Update the redirects for Ansible 11 and remove the unneeded 2.10 redirects.
part of ansible/ansible-documentation#2013

@samccann samccann requested a review from oraNod November 19, 2024 20:30
@oraNod
Copy link
Collaborator

oraNod commented Nov 20, 2024

@samccann are you sure we can't just do a one-time renaming of 10 to latest?

I believe the point of those redirects is so any links such as this one: https://docs.ansible.com/ansible/latest/modules/k8s_module.html referenced from this blog post on ansible.com do not 404. Unfortunately that particular link still causes a 404 because the target url is out of date collections/community/kubernetes/k8s_module.html.

The current batch of redirects under the 10 folder handle links to content in the modules and plugins subdirectories for the latest branch.

The latest symlink is on the server to point to the correct version whether that is 10 or 11. By renaming the folder to latest you should be able to just rename this folder once and stop doing it every time there is a new Ansible package version.

@oraNod
Copy link
Collaborator

oraNod commented Nov 20, 2024

+1 to removing the 2.10 redirects.

@samccann
Copy link
Collaborator Author

Mentioned this in a chat thread but do we want to do this PR at all or just 'live with it as is' until RTD land comes in with the new batch of redirects?

@oraNod
Copy link
Collaborator

oraNod commented Nov 21, 2024

Mentioned this in a chat thread but do we want to do this PR at all or just 'live with it as is' until RTD land comes in with the new batch of redirects?

Not sure what you mean by RTD land. Maybe let's just go ahead and merge this and carry on with the release process as normal? Since part of the redirect consolidation includes a new collections.html page we should give community a heads up before we put that in place.

Copy link
Collaborator

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Let's go ahead and merge so we can get through the release checklist for 11. We can do new stuff on top of this.

Now that we can have confidence in the consolidated redirects there's probably no point moving the 10 subdirectory to a latest subdirectory as I mentioned in another comment. However that would prevent the need to rename the folders if we weren't going to consolidate redirects.

@oraNod oraNod merged commit 576d5a6 into ansible:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants