Add lock to fix flaky test #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## devel #1261 +/- ##
==========================================
+ Coverage 39.80% 40.24% +0.43%
==========================================
Files 45 48 +3
Lines 9376 9995 +619
==========================================
+ Hits 3732 4022 +290
- Misses 5354 5677 +323
- Partials 290 296 +6
... and 6 files with indirect coverage changes
|
matoval
changed the title
|
Strange, it looks like UntilWithSync is still causing a data race. 🤔 |
AaronH88
reviewed
Feb 6, 2025
pkg/workceptor/workunitbase.go
Outdated
| @@ -402,7 +404,9 @@ func (bwu *BaseWorkUnit) MonitorLocalStatus() { | |||
| watcherErrors = make(chan error) | |||
|
|
|||
| if bwu.watcher != nil { | |||
| watcherLock.Lock() | |||
There was a problem hiding this comment.
Strange that we need this.
Have you tried using the existing status file lock?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lock to fix flaky test