Refactor group resource #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
hakbailey
approved these changes
Feb 19, 2024
internal/provider/group_resource.go
Outdated
Comment on lines
41
to
56
| func (d *GroupResource) Configure(_ context.Context, req resource.ConfigureRequest, resp *resource.ConfigureResponse) { | ||
| if req.ProviderData == nil { | ||
| return | ||
| } | ||
|
|
||
| client, ok := req.ProviderData.(*AAPClient) | ||
| if !ok { | ||
| resp.Diagnostics.AddError( | ||
| "Unexpected Resource Configure Type", | ||
| fmt.Sprintf("Expected *AAPClient, got: %T. Please report this issue to the provider developers.", req.ProviderData), | ||
| ) | ||
|
|
||
| return | ||
| } | ||
|
|
||
| d.client = client |
There was a problem hiding this comment.
Suggested change
| func (d *GroupResource) Configure(_ context.Context, req resource.ConfigureRequest, resp *resource.ConfigureResponse) { | |
| if req.ProviderData == nil { | |
| return | |
| } | |
| client, ok := req.ProviderData.(*AAPClient) | |
| if !ok { | |
| resp.Diagnostics.AddError( | |
| "Unexpected Resource Configure Type", | |
| fmt.Sprintf("Expected *AAPClient, got: %T. Please report this issue to the provider developers.", req.ProviderData), | |
| ) | |
| return | |
| } | |
| d.client = client | |
| func (r *GroupResource) Configure(_ context.Context, req resource.ConfigureRequest, resp *resource.ConfigureResponse) { | |
| if req.ProviderData == nil { | |
| return | |
| } | |
| client, ok := req.ProviderData.(*AAPClient) | |
| if !ok { | |
| resp.Diagnostics.AddError( | |
| "Unexpected Resource Configure Type", | |
| fmt.Sprintf("Expected *AAPClient, got: %T. Please report this issue to the provider developers.", req.ProviderData), | |
| ) | |
| return | |
| } | |
| r.client = client |
It doesn't really matter what variable we use here but probably best to keep it consistent throughout the file.
internal/provider/group_resource.go
Outdated
| err := json.Unmarshal(body, &result) | ||
| if err != nil { | ||
| return err | ||
| // Create request body from host data |
There was a problem hiding this comment.
Suggested change
| // Create request body from host data | |
| // Create request body from group data |
internal/provider/group_resource.go
Outdated
|
|
||
| // Read Terraform plan data into the model | ||
| resp.Diagnostics.Append(req.State.Get(ctx, &data)...) | ||
| // Update host in AAP |
There was a problem hiding this comment.
Suggested change
| // Update host in AAP | |
| // Update group in AAP |
| // Schema defines the schema for the group resource. | ||
| func (r *GroupResource) Schema(_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) { | ||
| resp.Schema = schema.Schema{ | ||
| Attributes: map[string]schema.Attribute{ | ||
|
|
There was a problem hiding this comment.
Could we update the group_url attribute to just be url? It seems redundant to indicate that it is the URL for the group object.
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
GomathiselviS
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor group resource