Merge pull request #5 from answear/skip-unknown-services

Skip unknown services
answear · May 4, 2021 · 125b886 · 125b886
2 parents bb295d5 + 13cd2e6
commit 125b886
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Service/PUDOFactory.php b/src/Service/PUDOFactory.php
@@ -51,7 +51,11 @@ private function createAdditionalInfo(\SimpleXMLElement $xml): AdditionalInfo
     {
         $info = new AdditionalInfo();
         foreach (explode(';', (string) $xml->SERVICE_PUDO) as $service) {
-            $info->services[] = Service::byValue($service);
+            try {
+                $info->services[] = Service::byValue($service);
+            } catch (\InvalidArgumentException $e) {
+                // NOP, do not fail hard for new services
+            }
         }
         $info->wheelchairAccessible = 'true' === (string) $xml->HANDICAPE;
         $info->parking = 'true' === (string) $xml->PARKING;

diff --git a/tests/fixtures/full_pudo.xml b/tests/fixtures/full_pudo.xml
@@ -5,7 +5,7 @@
             <PUDO_ID>PL15625</PUDO_ID>
             <ORDER>1</ORDER>
             <PUDO_TYPE>100</PUDO_TYPE>
-            <SERVICE_PUDO>100;200;201</SERVICE_PUDO>
+            <SERVICE_PUDO>100;200;201;THIS_DOES_NOT_EXIST</SERVICE_PUDO>
             <LANGUAGE>PL</LANGUAGE>
             <ADDRESS1>Na Szaniec 21 box 4</ADDRESS1>
             <ADDRESS2>ADDRESS2</ADDRESS2>