-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: Update numpy requirement to >=1.20.0,<2.2 #5116
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@svandenb-dev This PR won't be able to pass until a new release of |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5116 +/- ##
=======================================
Coverage 83.47% 83.48%
=======================================
Files 128 128
Lines 57473 57470 -3
=======================================
Hits 47977 47977
+ Misses 9496 9493 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be added after success of the CI workflow.
@Samuelopez-ansys Let me know if you want to remove the changes that are currently added here about using cache in CICD. I had to remove it to ensure that |
Seems like the fix is not working when adding back |
As title says. Changes include:
cdouble
instead of the long deprecatedcomplex_
when definingdtype
withnumpy
functions;pytomlpp
totoml
;The reason for the switch in
toml
dependency is related to two facts:numpy>=2.0
+pytomlpp
. Indeed, in Linux, we end up loading thelibPyDesktopPlugin.so
file (seepyaedt/src/ansys/aedt/core/generic/grpc_plugin_dll_class.py
Line 292 in c098962
pytomlpp
works as we are no longer able to load a TOML file. Seetoml
does provide read and write capabilities whiletomli
(a more standard package) does only provide read capabilities.