FEAT: ECAD import extension #5164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kathy Pippert <[email protected]>
for more information, see https://pre-commit.ci
…o refactor-pcb-parts-handling
Co-authored-by: Kathy Pippert <[email protected]>
…o refactor-pcb-parts-handling
…o ecad-import-extension
# Conflicts: # _unittest_solvers/test_45_workflows.py
# Conflicts: # _unittest/test_98_Icepak.py # _unittest_solvers/test_45_workflows.py # src/ansys/aedt/core/modules/boundary.py # src/ansys/aedt/core/workflows/circuit/ecad_importer.py # src/ansys/aedt/core/workflows/circuit/images/large/bitmap.svg # src/ansys/aedt/core/workflows/circuit/images/large/ecad.png # src/ansys/aedt/core/workflows/circuit/toolkits_catalog.toml
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5164 +/- ##
==========================================
- Coverage 83.26% 79.39% -3.87%
==========================================
Files 142 143 +1
Lines 58221 58266 +45
==========================================
- Hits 48475 46263 -2212
- Misses 9746 12003 +2257 |
lorenzovecchietti
requested review from
siva-krishnaswamy and
Samuelopez-ansys
There was a problem hiding this comment.
Hi @lorenzovecchietti , Instead of tk logo, we can use ansys logo. It is already there in workflow directory.
icon_path = os.path.join(pyaedt.workflows.path[0], "images", "large", "logo.png")
There was a problem hiding this comment.
Hi @lorenzovecchietti, Does the devices in CSV part of PCB component ? If not, Can we have a toggle button which will create the components outside the PCB 3D component ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.