Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ellipsis): Use React life cycle hooks to avoid render not correct in Suspense #6770

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 29, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Preview is ready

Copy link

cloudflare-workers-and-pages bot commented Oct 29, 2024

Deploying ant-design-mobile with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6cfeb5
Status: ✅  Deploy successful!
Preview URL: https://25f09119.ant-design-mobile.pages.dev
Branch Preview URL: https://fix-ellipsis.ant-design-mobile.pages.dev

View logs

Copy link
Contributor

Size Change: -414 B (-0.11%)

Total Size: 370 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 198 kB -140 B (-0.07%)
./lib/bundle/antd-mobile.umd.js 152 kB -274 B (-0.18%)
ℹ️ View Unchanged
Filename Size
./lib/bundle/css-vars-patch.css 1.63 kB
./lib/bundle/style.css 18.5 kB

compressed-size-action

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./lib/bundle/antd-mobile.es.js 107.69 KB 2.2 s (0%) 1.3 s (+8.08% 🔺) 3.4 s

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.70%. Comparing base (c4e181d) to head (c6cfeb5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/components/ellipsis/useMeasure.tsx 97.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6770      +/-   ##
==========================================
- Coverage   92.74%   92.70%   -0.04%     
==========================================
  Files         334      335       +1     
  Lines        7204     7192      -12     
  Branches     1763     1801      +38     
==========================================
- Hits         6681     6667      -14     
- Misses        515      517       +2     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit a36e90b into master Oct 29, 2024
14 checks passed
@zombieJ zombieJ deleted the fix-ellipsis branch October 29, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants