Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown 关闭没有动画效果 #6813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −3
Open

fix: dropdown 关闭没有动画效果 #6813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/components/dropdown/item.tsx
View file
Original file line number Diff line number Diff line change
@@ -75,9 +75,7 @@ export const ItemChildrenWrap: FC<DropdownItemChildrenWrapProps> = props => {
props.forceRender,
props.destroyOnClose
)
const cls = classNames(`${classPrefix}-content`, {
[`${classPrefix}-content-hidden`]: !active,
})
const cls = classNames(`${classPrefix}-content`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否可以监听一下动画，结束了加上 hidden。否则元素一直都会留在那里

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

捕获
我看Popup组件那里顶层已经有了，是不是可以不用再dropdown这里加了


return shouldRender ? (
<div className={cls} onClick={props.onClick}>
Loading