test: ConnectModal components test coverage #483
Conversation
🦋 Changeset detectedLatest commit: 7d62342 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
.changeset/angry-years-explode.md
Outdated
| '@ant-design/web3': patch | ||
| --- | ||
|
|
||
| test:connect-modal components test coverage |
There was a problem hiding this comment.
| test:connect-modal components test coverage | |
| test: ConnectModal components test coverage |
| const App = () => <DefaultGuidePanel guide={Guide as unknown as DefaultGuide} />; | ||
| const { baseElement } = render(<App />); | ||
| // Show icon only if icon is string | ||
| expect(baseElement.querySelector('.ant-web3-connect-modal-guide-item-icon')).toBeNull(); |
There was a problem hiding this comment.
icon 是 ReactNode 的时候应该也要能展示，比如是一个 svg 的时候。
There was a problem hiding this comment.
是会显示，但是这边组件内部的逻辑是ant-web3-connect-modal-guide-item-icon 这个classname只有在是icon是url的时候才显示。
There was a problem hiding this comment.
想了想原来的数字确实不太合适，现在换成了web3-icons
thinkasany
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 99.33% 99.54% +0.21%
==========================================
Files 92 92
Lines 4216 4216
Branches 430 433 +3
==========================================
+ Hits 4188 4197 +9
+ Misses 27 18 -9
Partials 1 1 ☔ View full report in Codecov by Sentry. |
No description provided.