Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: modify APIs from connector #498

Merged
merged 11 commits into from
Jan 17, 2024

Conversation

shanchuan1
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jan 16, 2024

⚠️ No Changeset found

Latest commit: e120b9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 9:22am

Copy link

github-actions bot commented Jan 16, 2024

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf6c520) 99.62% compared to head (e120b9c) 99.62%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          95       95           
  Lines        4249     4249           
  Branches      425      425           
=======================================
  Hits         4233     4233           
  Misses         15       15           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkasany
Copy link
Collaborator

thinkasany commented Jan 16, 2024

可以用rebase 或者 reset 整理一下以上无关本pr的commit
image

| balance | Balance of the currently connected account | `Balance[]` \| `Balance` | - | - |
| availableChains | Available chains | `Chain[]` | - | - |
Copy link
Collaborator

@thinkasany thinkasany Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边的翻译倒是可以问一下 @yutingzhao1991 ,帮忙顺便统一一下文档的英文描述,出现两种了。
是不是应该 换成 List of available chains 好一点

image

image

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

差不多,就保持统一好了。

@thinkasany thinkasany changed the title docs: Delete Unreferenced APIs from connector fix: Modify the content of ConnectButton message & Modify the document of Connector Jan 16, 2024
@thinkasany thinkasany changed the title fix: Modify the content of ConnectButton message & Modify the document of Connector fix: Modify the content of ConnectButton message & document of Connector Jan 16, 2024
@thinkasany thinkasany changed the title fix: Modify the content of ConnectButton message & document of Connector fix: Modify ConnectButton's message content & document of Connector Jan 16, 2024
@thinkasany thinkasany changed the title fix: Modify ConnectButton's message content & document of Connector docs: Delete Unreferenced APIs from connector Jan 16, 2024
@thinkasany thinkasany changed the title docs: Delete Unreferenced APIs from connector docs: modify APIs from connector Jan 16, 2024
@yutingzhao1991 yutingzhao1991 merged commit 501e477 into ant-design:main Jan 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants