Apply suggestions from code review

Co-authored-by: Ben McCann <[email protected]>
antfu-collective · Aug 26, 2024 · 7782135 · 7782135
1 parent 54eaeb3
commit 7782135
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -62,7 +62,7 @@
     "picocolors": "^1.0.1",
     "taze": "^0.16.3",
     "terminal-link": "^3.0.0",
-    "tinyexec": "^0.2.0",
+    "tinyexec": "^0.3.0",
     "tinyglobby": "^0.2.2",
     "tsx": "^4.17.0",
     "typescript": "^5.5.4",

diff --git a/src/detect.ts b/src/detect.ts
@@ -51,6 +51,7 @@ export async function detect({ autoInstall, programmatic, cwd }: DetectOptions =
           stdio: 'inherit',
           cwd,
         },
+        throwOnError: true,
       },
     )
   }

diff --git a/src/runner.ts b/src/runner.ts
@@ -90,6 +90,7 @@ export async function run(fn: Runner, args: string[], options: DetectOptions = {
       nodeOptions: {
         cwd,
       },
+      throwOnError: true,
     } satisfies Partial<TinyExecOptions>
     const getV = (a: string) => {
       const [command, ...xArguments] = getCmd(a as Agent).split(' ')
@@ -155,5 +156,6 @@ export async function run(fn: Runner, args: string[], options: DetectOptions = {
       stdio: 'inherit',
       cwd,
     },
+    throwOnError: true,
   })
 }
-Original file line number
+Diff line change
@@ Expand Up @@
               stdio: 'inherit',
               cwd,
             },
+            throwOnError: true,
           },
         )
       }
@@ Expand Down @@