Whammy.js encode webp image array in safari fails #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich does not support webp, but atob function which uses inside webp is not cross browser compatible so whammy.js break in safari, this fix added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whammy.js can encode webp image array to webm format even in the browsers that does not support webp image format.
simply using a flash object we can get an array of webp, or using libwebp.js we can convert other image format to webp and then use whammy.js to encode those images to webm. this workaround is working on all the latest browers except safari. with this fix even though safari can't playback webm format, webm will be created success fully
Here is another effort to make whammy.js cross browser compatible
https://github.com/imalhasaranga/whammy-cross-browser-demo