Adding an option to open links in a new window #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 23, 2011 15:14
This reverts commit 162fafa.
| @@ -48,9 +48,12 @@ function submit() { | |||
| } | |||
|
|
|||
| function update_profile() { | |||
| var checked = '0'; | |||
| if($('input[name=new_window]').is(':checked')) checked = '1'; | |||
There was a problem hiding this comment.
You're aware that you've used mis-matched whitespace correct?
Contrary to the rest of the code...
- You've omitted curly braces
- You're using a different quote style (single? the rest uses double)
There was a problem hiding this comment.
Ah! I hope you'll excuse my newness to contributing to open-source, I didn't even realize things like these mattered. I'll get right on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has always been a feature that I've looked for in HN. It just adds a simple checkbox to the user's preferences page which allows them to decide whether or not they want links to open in new windows.