Refactoring Loaders & Renders #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gido
requested changes
Apr 11, 2017
| * Load a given block with or whitout parameters. | ||
| */ | ||
| public function renderForm($module, $form, $params = []) { | ||
| return $this->getFormBuilder()->getForm('Drupal\\' . $module . '\Form\\' . $form, $params); |
| } | ||
|
|
||
| /** | ||
| * Load a given block with or whitout parameters. |
| } | ||
|
|
||
| /** | ||
| * Load a given block with or whitout parameters. |
| * @return array | ||
| * A render array to display the region content. | ||
| */ | ||
| public function renderRegion($region, $theme = NULL) { |
There was a problem hiding this comment.
I propose to remove this feature.
I don't see the usecase
| * @param mixed $id | ||
| * (optional) The ID of the entity to render. | ||
| * @param string $formatter | ||
| * (optional) The formatter that should be used to render the field. |
| * @return null|array | ||
| * A render array for the field or NULL if the value does not exist. | ||
| */ | ||
| public function renderField($field_name, $entity_type, $id = NULL, $formatter = NULL, $langcode = NULL) { |
| } | ||
|
|
||
| if (isset($entity->{$field_name})) { | ||
| return $entity->{$field_name}->view($display_options); |
There was a problem hiding this comment.
I prefer $entity->get($field_name)
| new \Twig_SimpleFunction('bamboo_load_entity', [$this, 'loadEntity']), | ||
| new \Twig_SimpleFunction('bamboo_load_field', [$this, 'loadField']), | ||
| new \Twig_SimpleFunction('bamboo_load_currentuser', [$this, 'loadCurrentUser']), | ||
| new \Twig_SimpleFunction('bamboo_load_image', [$this, 'loadImage']), |
There was a problem hiding this comment.
Create a issue for this here : #7
People will chose.
| <h2>Loader Image</h2> | ||
| <hr> | ||
| {% set image = bamboo_load_image('public://antistatique.png') %} | ||
| <div class="loader-image-uri">{{ image.getSource }}</div> |
There was a problem hiding this comment.
replace by image.getSource() if this is a method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged, should refactore also every other Twig Extension to use the new Drupal\bamboo_twig\TwigExtensionTwigExtensionBase.
Loader
run test with
../../vendor/bin/phpunit --group bamboo_twig_loader --printer="\Drupal\Tests\Listeners\HtmlOutputPrinter"Render
run test with
../../vendor/bin/phpunit --group bamboo_twig_render --printer="\Drupal\Tests\Listeners\HtmlOutputPrinter"or more globally with
../../vendor/bin/phpunit --group bamboo_twig --printer="\Drupal\Tests\Listeners\HtmlOutputPrinter"