fix(derive): Span batch bitlist encoding #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Overview Fixes the spanbatch bitlist encoding by following the spec of Golang's `big.Int`. Internally, this type uses a big-endian, zero-padded array of u8s, and when the number grows, it extends itself left in memory. **Metadata** closes #112
clabby
force-pushed
the
cl/span-batch-bits
branch
from
6d5f9c7
to
54a1cb0
Compare
refcell
approved these changes
Apr 19, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the spanbatch bitlist encoding by following the spec of Golang's
big.Int. Internally, this type uses a big-endian, zero-padded array of u8s, and when the number grows, it extends itself left in memory.Metadata
closes #112