Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Use L2ChainProvider for system config fetching in attributes builder #123

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Apr 19, 2024

Overview

Reuses the L2ChainProvider for fetching the SystemConfig at a given block, rather than having an exlusive trait that extends the L2ChainProvider.

@clabby clabby added K-feature Kind: feature A-derive Area: kona-derive crate labels Apr 19, 2024
@clabby clabby marked this pull request as draft April 19, 2024 08:04
…ributes builder

Reuses the `L2ChainProvider` for fetching the `SystemConfig` at a given
block, rather than having an exlusive trait that extends the
`L2ChainProvider`.

Fix tests
@clabby clabby marked this pull request as ready for review April 19, 2024 16:57
@clabby clabby requested a review from refcell April 19, 2024 16:57
@clabby clabby self-assigned this Apr 19, 2024
@refcell refcell added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 0587b4d Apr 19, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
@clabby clabby deleted the cl/sys-cfg-payload branch April 19, 2024 17:38
clabby added a commit that referenced this pull request Apr 19, 2024
## Overview

Rebases the span batch validation tests on top of #123
github-merge-queue bot pushed a commit that referenced this pull request Apr 19, 2024
## Overview

Rebases the span batch validation tests on top of #123
This was referenced May 29, 2024
This was referenced Jun 6, 2024
This was referenced Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants