Skip to content

Commit

Permalink
[e2e tests] Remove custom timeout value for coverage image
Browse files Browse the repository at this point in the history
There should no longer be a need for a custom timeout value in
testAntreaGracefulExit when coverage is enabled. The increased timeout
was not actually required for code coverage collection (which is qite
fast), but because of issues with the coverage-enabled image, which was
not handling signals correctly. After antrea-io#6090, this should have been
fixed.

Signed-off-by: Antonin Bas <[email protected]>
  • Loading branch information
antoninbas committed May 31, 2024
1 parent 264372d commit 8c1d060
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions test/e2e/basic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,13 +263,6 @@ func testAntreaGracefulExit(t *testing.T, data *TestData) {
var gracePeriodSeconds int64 = 60
t.Logf("Deleting one Antrea Pod")
maxDeleteTimeout := 20 * time.Second
// When running Antrea instrumented binary to collect e2e coverage,
// we need to set the maxDeleteTimeout to a larger value
// since it needs to collect coverage data files
if testOptions.enableCoverage {
maxDeleteTimeout = 80 * time.Second
}

if timeToDelete, err := data.deleteAntreaAgentOnNode(nodeName(0), gracePeriodSeconds, defaultTimeout); err != nil {
t.Fatalf("Error when deleting Antrea Pod: %v", err)
} else if timeToDelete > maxDeleteTimeout {
Expand Down

0 comments on commit 8c1d060

Please sign in to comment.