Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to customize the (localized) dialog #10

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

gallinaettore
Copy link

The dialog is translated into the most common languages.
Now you can customize the dialog.

Add possibility to customize the dialog
Add translation of the dialog
Add possibility to manually choose the language of the dialog
Add possibility to customize the dialog
Add translation of the dialog
Add possibility to manually choose the language of the dialog
Add possibility to customize the dialog
Add translation of the dialog
Add possibility to manually choose the language of the dialog
Add possibility to customize the dialog
Add translation of the dialog
Add possibility to manually choose the language of the dialog
Add possibility to customize the dialog
Add translation of the dialog
Add possibility to manually choose the language of the dialog
@antonmolchan
Copy link
Owner

antonmolchan commented May 5, 2021

@gallinaettore Hi, your changes so good, but i have some exceptions on compile.
On android have:
`A problem occurred evaluating project ':gdpr_dialog'.

Plugin with id 'kotlin-android' not found. `

I added Kotlin in buildscript and all works fine.

buildscript {
    ext.kotlin_version = '1.3.10'
    repositories {
        google()
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:3.6.3'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

On IOS build have another one exception
Cannot find type 'EGADialogStyle' in scope
and
Cannot find 'PACConsentInformation' in scope
Thats exception in SwiftGdprDialogPlugin.swift file.

Maybe you know how to fix that ?

@gallinaettore
Copy link
Author

Hello, I made some corrections to the sample project ;-)

@antonmolchan
Copy link
Owner

@gallinaettore Hi, sorry for long answers. Android build, but on ios have one more exception

    <module-includes>:1:9: note: in file included from <module-includes>:1:
    #import "Headers/gdpr_dialog-umbrella.h"
            ^
    /Users/anton/AndroidStudioProjects/gdpr_dialog_flutter/example/ios/Pods/Target Support Files/gdpr_dialog/gdpr_dialog-umbrella.h:17:9: note: in file included from
    /Users/anton/AndroidStudioProjects/gdpr_dialog_flutter/example/ios/Pods/Target Support Files/gdpr_dialog/gdpr_dialog-umbrella.h:17:
    #import "PACConsentForm.h"
            ^
    /Users/anton/AndroidStudioProjects/gdpr_dialog_flutter/ios/Classes/PACConsentForm.h:36:1: warning: conflicting nullability specifier on return types, 'nullable' conflicts with existing specifier
    'nonnull'
    - (nullable instancetype)init NS_UNAVAILABLE;
    ^
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk/usr/include/objc/NSObject.h:63:1: note: previous declaration is here
    - (instancetype)init
    ^
    /Users/anton/Library/Developer/Xcode/DerivedData/Runner-gcwelywgjwcviffldfpkbqcaeplj/Build/Intermediates.noindex/Runner.build/Debug-iphonesimulator/Runner.build/Script-BEB56E42BC0B8ECBDEEC42B7.sh:
    line 2: /Users/anton/AndroidStudioProjects/gdpr_dialog_flutter/example/ios/Pods/Target Support Files/Pods-Runner/Pods-Runner-frameworks.sh: Permission denied


Try to fix it, but do not know which file do I need to specifically edit.

@gallinaettore
Copy link
Author

Have you tried cleaning your Xcode DerivedData folder?

@antonmolchan
Copy link
Owner

Yep, i try to find same exception on stackoverflow but cant fix int (

@gallinaettore
Copy link
Author

I think you should probably clear the Xcode cache, to do this you need to clear the DerivedData folder (it will be created again by Xcode).

You can find a guide on how to cancel Derived Data here: https://iosdevcenters.blogspot.com/2015/12/how-to-delete-derived-data-and-clean.html

or https://programmingwithswift.com/delete-derived-data-xcode/

or https://www.raywenderlich.com/19998365-understanding-and-managing-xcode-space (Clearing Derived Data paragraph)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants