Apply suggestions from code review

Co-authored-by: Lan <[email protected]>
antrea-io · Apr 7, 2024 · 7131e9e · 7131e9e
1 parent 0d70668
commit 7131e9e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/pkg/agent/openflow/framework.go b/pkg/agent/openflow/framework.go
@@ -341,8 +341,8 @@ type traceableFeature interface {
 		timeoutSeconds uint16) []binding.Flow
 }
 
-type sampleFeature interface {
-	flowsToSample(dataplaneTag uint8,
+type samplingFeature interface {
+	flowsToSampling(dataplaneTag uint8,
 		ovsMetersAreSupported,
 		senderOnly bool,
 		receiverOnly bool,

diff --git a/pkg/agent/openflow/packetin.go b/pkg/agent/openflow/packetin.go
@@ -53,7 +53,7 @@ const (
 	// PacketInCategorySvcReject is used to process the Service packets not matching any
 	// Endpoints within packetIn message.
 	PacketInCategorySvcReject
-	// PacketSampling is used for packetIn messages related to sampling.
+	// PacketInCategoryPS is used for packetIn messages related to sampling.
 	PacketInCategoryPS
 
 	// PacketIn operations below are used to decide which operation(s) should be

diff --git a/pkg/agent/openflow/packetsampling.go b/pkg/agent/openflow/packetsampling.go
@@ -1,4 +1,4 @@
-// Copyright 2022 Antrea Authors
+// Copyright 2024 Antrea Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/pkg/agent/openflow/pipeline.go b/pkg/agent/openflow/pipeline.go
@@ -422,7 +422,7 @@ type client struct {
 	traceableFeatures []traceableFeature
 
 	featurePacketSampling *featurePacketSampling
-	sampleFeatures        []sampleFeature
+	samplingFeatures        []samplingFeature
 
 	pipelines map[binding.PipelineID]binding.Pipeline