Always run antctl in Pod for e2e tests (#5349)

* Always run antctl in Pod for e2e tests

Instead of copying the antctl binary to the Node.

This simplifies tests in the following ways:
* No need to generate a Kubeconfig using the kube-system/antctl
  ServiceAccount token. Instead we define a ServiceAccount in the test
  Namepace, bind the antctl ClusterRole to it, and use it for the antctl
  Pod.
* No need to use different antctl binary paths for Kind and VMs.
* Easier lifecyle management when running antctl proxy.

We also remove the assumption that curl is available on the
control-plane Node.

Signed-off-by: Antonin Bas <[email protected]>

build/images/Dockerfile.build.coverage

@@ -25,10 +25,9 @@ RUN go mod download
 COPY . /antrea
 
 RUN make antrea-agent antrea-controller antrea-cni antrea-controller-instr-binary antrea-agent-instr-binary
-# The e2e tests for antctl currently copy the antctl binary from the Docker container
-# to the host Node, and run the binary from the host. The host may be missing some
-# system libraries that are required to run the binary, so we need to disable CGO
-# to avoid such dependencies and ensure that the binary is portable.
+# Disable CGO for antctl in case it is copied outside of the container image. It
+# also reduces the size of the binary and aligns with how we distribute antctl
+# in release assets.
 RUN CGO_ENABLED=0 make antctl-linux antctl-instr-binary
 RUN mv bin/antctl-linux bin/antctl
 

build/images/Dockerfile.build.ubi

@@ -25,9 +25,9 @@ RUN go mod download
 COPY . /antrea
 
 RUN make antrea-agent antrea-controller antrea-cni
-# Disable CGO for antctl in case it is copied outside of the container image,
-# such as in e2e tests. It also reduces the size of the binary and aligns with
-# how we distribute antctl in release assets.
+# Disable CGO for antctl in case it is copied outside of the container image. It
+# also reduces the size of the binary and aligns with how we distribute antctl
+# in release assets.
 RUN CGO_ENABLED=0 make antctl-linux
 RUN mv bin/antctl-linux bin/antctl
 

build/images/Dockerfile.build.ubuntu

@@ -25,9 +25,9 @@ RUN go mod download
 COPY . /antrea
 
 RUN make antrea-agent antrea-controller antrea-cni
-# Disable CGO for antctl in case it is copied outside of the container image,
-# such as in e2e tests. It also reduces the size of the binary and aligns with
-# how we distribute antctl in release assets.
+# Disable CGO for antctl in case it is copied outside of the container image. It
+# also reduces the size of the binary and aligns with how we distribute antctl
+# in release assets.
 RUN CGO_ENABLED=0 make antctl-linux
 RUN mv bin/antctl-linux bin/antctl