[Not4Review]Change to include unit test data only #4616

luolanzone · 2023-02-09T07:38:59Z

The purpose of this PR is to track latest unit test coverage data on Codecov.

Signed-off-by: Lan Luo [email protected]

codecov · 2023-02-09T08:11:44Z

Codecov Report

Merging #4616 (b0aa950) into main (6d76ddf) will increase coverage by 1.45%.
The diff coverage is n/a.

❗ Current head b0aa950 differs from pull request most recent head bf9eeb5. Consider uploading reports for the commit bf9eeb5 to get more accurate results

@@            Coverage Diff             @@
##             main    #4616      +/-   ##
==========================================
+ Coverage   68.64%   70.10%   +1.45%     
==========================================
  Files         400      376      -24     
  Lines       59450    57192    -2258     
==========================================
- Hits        40809    40092     -717     
+ Misses      15807    14341    -1466     
+ Partials     2834     2759      -75

Flag	Coverage Δ		*Carryforward flag
e2e-tests	`38.34% <ø> (ø)`		Carriedforward from 6d76ddf
integration-tests	`34.53% <ø> (ø)`		Carriedforward from 6d76ddf
kind-e2e-tests	`40.46% <ø> (ø)`		Carriedforward from 6d76ddf
unit-tests	`60.84% <ø> (+1.08%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
pkg/features/antrea_features.go	`64.00% <0.00%> (-36.00%)`	⬇️
pkg/apiserver/handlers/endpoint/handler.go	`56.52% <0.00%> (-13.05%)`	⬇️
cmd/antrea-agent/options.go	`31.99% <0.00%> (-4.98%)`	⬇️
pkg/util/env/env.go	`58.73% <0.00%> (-4.77%)`	⬇️
pkg/antctl/runtime/runtime.go	`33.33% <0.00%> (-3.34%)`	⬇️
...catesigningrequest/ipsec_csr_signing_controller.go	`61.65% <0.00%> (-2.46%)`	⬇️
pkg/agent/cniserver/ipam/ipam_service.go	`81.72% <0.00%> (-2.16%)`	⬇️
pkg/controller/externalippool/controller.go	`84.37% <0.00%> (-1.79%)`	⬇️
pkg/flowaggregator/flowaggregator.go	`71.49% <0.00%> (-1.54%)`	⬇️
...gent/controller/noderoute/node_route_controller.go	`66.91% <0.00%> (-1.37%)`	⬇️
... and 29 more

wenqiq · 2023-02-10T15:13:37Z

There is already a branch codecov-ut created by PR #4310 in codecov(https://app.codecov.io/gh/antrea-io/antrea/tree/codecov-ut) and I think it’s not needed to create a new branch just for tracking the latest unit test coverage.

luolanzone · 2023-02-12T09:01:14Z

@wenqiq I think it's better to use a branch in antrea repo instead of a personal branch to track the unit test coverage considering it will be a long running PR. I have also removed unused github workflows to avoid unnecessary runner resource usage. You can update the branch codecov-ut-only in the future directly.

luolanzone · 2023-08-04T07:59:51Z

@CodiumAI-Agent /review

CodiumAI-Agent · 2023-08-04T08:00:24Z

PR Analysis

🎯 Main theme: Refactoring of GitHub Actions workflows to focus on unit test coverage
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
✨ Focused PR: Yes, the PR is focused as it is clearly aimed at refactoring the GitHub Actions workflows to focus on unit test coverage. All changes in the PR are related to this goal.
🔒 Security concerns: No, this PR does not introduce any obvious security concerns. It primarily involves changes to the CI/CD configuration, which should not affect the application's security.

PR Feedback

💡 General PR suggestions: The PR is generally well-structured and focused. However, it would be beneficial to provide more context in the PR description about why this change is necessary. Additionally, it would be helpful to explain why certain workflows were deleted and how this impacts the overall project. Lastly, it's important to ensure that the removal of certain workflows (like 'kind.yml', 'build.yml', 'conformance.yml', 'golicense.yml') won't negatively impact the project's quality assurance processes.

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR.
/ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."

rajnkamr · 2023-08-04T11:43:23Z

@CodiumAI-Agent /improve

CodiumAI-Agent · 2023-08-04T11:44:27Z

.github/workflows/go.yml

  test-unit-ubuntu:
-    needs: check-changes
-    if: ${{ needs.check-changes.outputs.has_changes == 'yes' }}
    name: Unit test (ubuntu-latest)
    runs-on: [ubuntu-latest]
    steps:
    - name: Check-out code
      uses: actions/checkout@v3
    - name: Set up Go using version from go.mod
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v3
      with:
        go-version-file: 'go.mod'


Suggestion: Consider using a matrix strategy for the setup-go action to avoid duplicating code for different operating systems.

Suggested change

test-unit-ubuntu:

needs: check-changes

if: ${{ needs.check-changes.outputs.has_changes == 'yes' }}

name: Unit test (ubuntu-latest)

runs-on: [ubuntu-latest]

steps:

- name: Check-out code

uses: actions/checkout@v3

- name: Set up Go using version from go.mod

uses: actions/setup-go@v4

uses: actions/setup-go@v3

with:

go-version-file: 'go.mod'

jobs:

test-unit:

strategy:

matrix:

os: [ubuntu-latest, windows-2019]

name: Unit test (${{ matrix.os }})

runs-on: ${{ matrix.os }}

steps:

- name: Set up Go using version from go.mod

uses: actions/setup-go@v3

with:

go-version-file: 'go.mod'

CodiumAI-Agent · 2023-08-04T11:44:27Z

.github/workflows/go.yml

+    - uses: actions/cache@v3
+      with:
+        # In order:
+        # * Module download cache
+        # * Build cache (Linux)
+        # * Build cache (Mac)
+        path: |
+          ~/go/pkg/mod
+          ~/.cache/go-build
+          ~/Library/Caches/go-build
+          %LocalAppData%\go-build
+        key: ${{ runner.os }}-${{ env.go-cache-name }}-${{ hashFiles('**/go.sum') }}
+        restore-keys: |
+          ${{ runner.os }}-${{ env.go-cache-name }}-
    - name: Run unit tests


Suggestion: Consider using a matrix strategy for the cache action to avoid duplicating code for different operating systems.

Suggested change

- uses: actions/cache@v3

with:

# In order:

# * Module download cache

# * Build cache (Linux)

# * Build cache (Mac)

path: |

~/go/pkg/mod

~/.cache/go-build

~/Library/Caches/go-build

%LocalAppData%\go-build

key: ${{ runner.os }}-${{ env.go-cache-name }}-${{ hashFiles('**/go.sum') }}

restore-keys: |

${{ runner.os }}-${{ env.go-cache-name }}-

- name: Run unit tests

jobs:

test-unit:

strategy:

matrix:

os: [ubuntu-latest, windows-2019]

steps:

- uses: actions/cache@v3

with:

path: |

~/go/pkg/mod

~/.cache/go-build

~/Library/Caches/go-build

%LocalAppData%\go-build

key: ${{ runner.os }}-${{ env.go-cache-name }}-${{ hashFiles('**/go.sum') }}

restore-keys: |

${{ runner.os }}-${{ env.go-cache-name }}-

CodiumAI-Agent · 2023-08-04T11:44:28Z

codecov.yaml

 flag_management:
  default_rules:
-    carryforward: true
+    carryforward: false


Suggestion: Consider setting 'carryforward' to true to keep the coverage from the last successful commit when a file has no coverage data for the current commit. This can prevent sudden drops in coverage.

Suggested change

carryforward: false

flag_management:

default_rules:

carryforward: true

luolanzone · 2023-12-01T06:47:28Z

This is test message

Signed-off-by: Rajnish K <[email protected]> Signed-off-by: Lan Luo <[email protected]> Signed-off-by: Kumar Atish <[email protected]>

luolanzone force-pushed the codecov-ut-only branch 3 times, most recently from a287c05 to b0aa950 Compare February 9, 2023 07:52

luolanzone force-pushed the codecov-ut-only branch from b0aa950 to bf9eeb5 Compare February 9, 2023 08:26

luolanzone mentioned this pull request Feb 9, 2023

[Not4review][UT test coverage reference]codecov-ut #4310

Closed

luolanzone force-pushed the codecov-ut-only branch 2 times, most recently from f9b72fc to 2933e97 Compare February 23, 2023 10:16

luolanzone force-pushed the codecov-ut-only branch from 2933e97 to f435f55 Compare March 2, 2023 12:48

Atish-iaf force-pushed the codecov-ut-only branch from f435f55 to f751c5d Compare March 3, 2023 09:03

rajnkamr force-pushed the codecov-ut-only branch from f751c5d to af1d780 Compare March 4, 2023 16:05

Atish-iaf force-pushed the codecov-ut-only branch from af1d780 to bc3ba6f Compare March 9, 2023 10:10

rajnkamr force-pushed the codecov-ut-only branch 4 times, most recently from 7792b00 to c001763 Compare March 17, 2023 13:58

luolanzone force-pushed the codecov-ut-only branch from c001763 to 300498d Compare March 24, 2023 02:40

rajnkamr force-pushed the codecov-ut-only branch 2 times, most recently from f3c5e0a to 743ef4c Compare April 6, 2023 05:42

rajnkamr force-pushed the codecov-ut-only branch from 743ef4c to e690e82 Compare April 13, 2023 15:09

rajnkamr force-pushed the codecov-ut-only branch from e690e82 to cf97c70 Compare April 27, 2023 13:19

luolanzone force-pushed the codecov-ut-only branch from cf97c70 to 3d9e695 Compare April 28, 2023 02:21

rajnkamr force-pushed the codecov-ut-only branch from 3d9e695 to 60610c0 Compare May 4, 2023 10:19

rajnkamr force-pushed the codecov-ut-only branch from 60610c0 to caac0f6 Compare May 18, 2023 05:16

rajnkamr force-pushed the codecov-ut-only branch from caac0f6 to af92258 Compare May 25, 2023 06:24

rajnkamr force-pushed the codecov-ut-only branch 2 times, most recently from 46fe043 to 745523d Compare June 8, 2023 14:52

rajnkamr force-pushed the codecov-ut-only branch from 745523d to dbcec11 Compare June 15, 2023 15:48

CodiumAI-Agent reviewed Aug 4, 2023

View reviewed changes

rajnkamr force-pushed the codecov-ut-only branch from 86b92e2 to 4f34af2 Compare August 16, 2023 04:21

rajnkamr force-pushed the codecov-ut-only branch from 4f34af2 to 212ab5e Compare August 24, 2023 13:53

rajnkamr force-pushed the codecov-ut-only branch from 212ab5e to c7967e7 Compare September 7, 2023 07:41

rajnkamr force-pushed the codecov-ut-only branch from c7967e7 to 6aa834f Compare September 20, 2023 15:02

rajnkamr force-pushed the codecov-ut-only branch 2 times, most recently from b495b52 to 172006f Compare October 16, 2023 07:19

rajnkamr force-pushed the codecov-ut-only branch from 172006f to 68e3bb0 Compare October 16, 2023 13:51

rajnkamr force-pushed the codecov-ut-only branch from 68e3bb0 to 6ce2aba Compare October 30, 2023 05:37

rajnkamr force-pushed the codecov-ut-only branch from 6ce2aba to fc16302 Compare November 16, 2023 09:48

rajnkamr force-pushed the codecov-ut-only branch from fc16302 to 5fadb93 Compare November 30, 2023 14:02

rajnkamr force-pushed the codecov-ut-only branch from 5fadb93 to 7e3ba37 Compare December 19, 2023 08:36

rajnkamr force-pushed the codecov-ut-only branch from 7e3ba37 to 00fb7c1 Compare January 18, 2024 06:42

rajnkamr force-pushed the codecov-ut-only branch from 00fb7c1 to 2f5018b Compare February 22, 2024 10:10

rajnkamr force-pushed the codecov-ut-only branch from 2f5018b to 7910c4f Compare March 7, 2024 06:30

rajnkamr force-pushed the codecov-ut-only branch from 7910c4f to 0f8f084 Compare March 21, 2024 05:33

rajnkamr force-pushed the codecov-ut-only branch from 0f8f084 to d90d6ce Compare April 18, 2024 14:18

rajnkamr force-pushed the codecov-ut-only branch from d90d6ce to e58fff2 Compare May 16, 2024 14:12

rajnkamr force-pushed the codecov-ut-only branch from e58fff2 to c7ee709 Compare June 13, 2024 05:59

rajnkamr force-pushed the codecov-ut-only branch from c7ee709 to 621c058 Compare June 26, 2024 08:22

rajnkamr force-pushed the codecov-ut-only branch from 621c058 to 286dee3 Compare July 8, 2024 06:05

rajnkamr force-pushed the codecov-ut-only branch 2 times, most recently from 12e96f4 to e13e355 Compare July 25, 2024 16:09

rajnkamr force-pushed the codecov-ut-only branch from e13e355 to c0409bb Compare August 13, 2024 07:22

Change to include unit test data only

5694ed7

Signed-off-by: Rajnish K <[email protected]> Signed-off-by: Lan Luo <[email protected]> Signed-off-by: Kumar Atish <[email protected]>

rajnkamr force-pushed the codecov-ut-only branch from c0409bb to 5694ed7 Compare September 4, 2024 14:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Not4Review]Change to include unit test data only #4616

[Not4Review]Change to include unit test data only #4616

luolanzone commented Feb 9, 2023

codecov bot commented Feb 9, 2023 •

edited

Loading

wenqiq commented Feb 10, 2023

luolanzone commented Feb 12, 2023

luolanzone commented Aug 4, 2023

CodiumAI-Agent commented Aug 4, 2023

rajnkamr commented Aug 4, 2023

CodiumAI-Agent Aug 4, 2023

CodiumAI-Agent Aug 4, 2023

CodiumAI-Agent Aug 4, 2023

luolanzone commented Dec 1, 2023

[Not4Review]Change to include unit test data only #4616

Are you sure you want to change the base?

[Not4Review]Change to include unit test data only #4616

Conversation

luolanzone commented Feb 9, 2023

codecov bot commented Feb 9, 2023 • edited Loading

Codecov Report

wenqiq commented Feb 10, 2023

luolanzone commented Feb 12, 2023

luolanzone commented Aug 4, 2023

CodiumAI-Agent commented Aug 4, 2023

PR Analysis

PR Feedback

How to use

rajnkamr commented Aug 4, 2023

CodiumAI-Agent Aug 4, 2023

Choose a reason for hiding this comment

CodiumAI-Agent Aug 4, 2023

Choose a reason for hiding this comment

CodiumAI-Agent Aug 4, 2023

Choose a reason for hiding this comment

luolanzone commented Dec 1, 2023

codecov bot commented Feb 9, 2023 •

edited

Loading