Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flows which are never used #5938

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

hongliangl
Copy link
Contributor

1. table=NodePortMark, priority=200,ipv6,nw_dst=::1 actions=set_field:0x80000/0x80000->reg4"
2. table=NodePortMark, priority=200,ip,nw_dst=127.0.0.1 actions=set_field:0x80000/0x80000->reg4
3. table=NodePortMark, priority=200,ip,nw_dst=192.168.77.102 actions=set_field:0x80000/0x80000->reg4
4. table=NodePortMark, priority=200,ip,nw_dst=172.17.0.1 actions=set_field:0x80000/0x80000->reg4
5. table=NodePortMark, priority=200,ip,nw_dst=169.254.0.252 actions=set_field:0x80000/0x80000->reg4
6. table=NodePortMark, priority=0 actions=goto_table:SessionAffinity

In table NodePortMark:

  • Flows 1-2, which were intended to match NodePort traffic from local Pods to loopback IP addresses, have been removed as they are never used.
  • Flows 3-5 are kept intact, as they are intended to match NodePort traffic from local Pods to specific Node IP addresses.
  • Flow 5 is to match NodePort traffic from local Node or external network, DNAT'd in Node by iptables.

Since that flows 1-2 are never used, remove them.

```
1. table=NodePortMark, priority=200,ipv6,nw_dst=::1 actions=set_field:0x80000/0x80000->reg4"
2. table=NodePortMark, priority=200,ip,nw_dst=127.0.0.1 actions=set_field:0x80000/0x80000->reg4
3. table=NodePortMark, priority=200,ip,nw_dst=192.168.77.102 actions=set_field:0x80000/0x80000->reg4
4. table=NodePortMark, priority=200,ip,nw_dst=172.17.0.1 actions=set_field:0x80000/0x80000->reg4
5. table=NodePortMark, priority=200,ip,nw_dst=169.254.0.252 actions=set_field:0x80000/0x80000->reg4
6. table=NodePortMark, priority=0 actions=goto_table:SessionAffinity
```

In table NodePortMark:

- Flows 1-2, which were intended to match NodePort traffic from local Pods
  to loopback IP addresses, have been removed as they are never used.
- Flows 3-5 are kept intact, as they are intended to match NodePort traffic
  from local Pods to specific Node IP addresses.
- Flow 5 is to match NodePort traffic from local Node or external network,
  DNAT'd in Node by iptables.

Since that flows 1-2 are never used, remove them.

Signed-off-by: Hongliang Liu <[email protected]>
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Jan 29, 2024

/skip-all

@tnqn tnqn merged commit 025c3f6 into antrea-io:main Jan 29, 2024
49 of 53 checks passed
@hongliangl hongliangl deleted the 20240129-remove-unsed-flow branch January 29, 2024 06:18
@hongliangl
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants