Add Action to NetworkPolicy Evaluation response #6112
Conversation
| } | ||
| assert.Equal(t, []string{"testName", "ns", "K8sNetworkPolicy", "10", "In"}, test.GetTableRow(32)) | ||
| assert.Equal(t, []string{"testName", "ns", "K8sNetworkPolicy", "10", "In", "Allow"}, test.GetTableRow(32)) |
There was a problem hiding this comment.
Quite misleading UT. K8s NP should not have action. We should use a testcase to test action "" and another at least to test outputting a real action
There was a problem hiding this comment.
That makes sense, but this also reminds me that for the manually inserted K8s default isolation rules, it's better to assign "Drop" to them for identification? Or perhaps an Index of max int is enough?
qiyueyao
force-pushed
the
action-npeval
branch
2 times, most recently
from
c54831e
to
a317d3a
Compare
pkg/apis/crd/v1beta1/types.go
Outdated
| // RuleActionIsolation indicates that the traffic matching the rule should be | ||
| // affected by Kubernetes NetworkPolicy default isolation. | ||
| RuleActionIsolation RuleAction = "Isolation" |
There was a problem hiding this comment.
Trying to understand this. Is this a real action or for other purpose? I feel it sounds a bit confusing. The existing actions are all verbs clearly stating what action will be taken, while "Isolation" describes a state. And I don't get its difference from "Pass".
There was a problem hiding this comment.
No I did not mean this should be a real action. And I agree that it does not make sense to be added to the CRD action type here. @qiyueyao what we want is simply a "isolate" string in the networkpolicyevaluation result if it is an isolation rule
There was a problem hiding this comment.
Understood, one question: if we want this "isolation" also in the API response, or just in the antctl response?
Currently added a step to identify default isolation rules in antctl processing, let me know if we also want it in API response (the place adding a real action, but a string instead of action constant).
Discussed offline: we don't want to add a fake action to API response, just process the response in antctl.
qiyueyao
force-pushed
the
action-npeval
branch
2 times, most recently
from
658e7e0
to
df954e0
Compare
|
@tnqn @antoninbas Do you have additional comments for setting |
| if r.Response.Rule.Action != nil { | ||
| action = string(*r.Response.Rule.Action) | ||
| } else if r.Response.RuleIndex == math.MaxInt32 { | ||
| action = "Isolation" |
There was a problem hiding this comment.
I think @tnqn suggested Isolate for this one (to stick to a verb), which I also prefer
There was a problem hiding this comment.
Sure, I misunderstood.
There was a problem hiding this comment.
Changed to "Isolate"
| } | ||
|
|
||
| func (r EvaluationResponse) GetTableRow(_ int) []string { | ||
| if r.NetworkPolicyEvaluation != nil && r.Response != nil { | ||
| action := "Allow" |
There was a problem hiding this comment.
maybe add a quick comment here explaining that this handling is to account for K8s NPs (r.Response.Rule.Action == nil corresponds to K8s NP "allow" and r.Response.RuleIndex == math.MaxInt32 corresponds to a drop action because of the "default isolation" model).
antoninbas
added
the
action/release-note
As necessary for networkpolicyevaluation consumption, this PR adds the Action field to the above antctl command response. Signed-off-by: Qiyue Yao <[email protected]>
|
/test-all |
As necessary for
networkpolicyevaluationconsumption, this PR adds theActionfield to the aboveantctlcommand response.