Do not try to update type of Secret in selfSignedCertProvider #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
reviewed
Apr 9, 2024
hangyan
reviewed
Apr 9, 2024
If a cluster used user provided certificate and created a Secret named antrea-controller-tls of Opaque type, changing to use self-signed certificate would fail because the type field is immutable. To support switching the certificate provider, we don't try to update the type of Secret if it already exists. Signed-off-by: Quan Tian <[email protected]>
tnqn
force-pushed
the
do-not-update-secret-type
branch
from
c6c5237 to
2961d58
Compare
hangyan
approved these changes
Apr 9, 2024
luolanzone
approved these changes
Apr 9, 2024
|
/test-all |
antoninbas
approved these changes
Apr 9, 2024
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Apr 10, 2024
…-io#6205) If a cluster used user-provided certificate and created a Secret named antrea-controller-tls of Opaque type, changing to use self-signed certificate would fail because the type field is immutable. To support switching the certificate provider, we don't try to update the type of Secret if it already exists. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Apr 10, 2024
…-io#6205) If a cluster used user-provided certificate and created a Secret named antrea-controller-tls of Opaque type, changing to use self-signed certificate would fail because the type field is immutable. To support switching the certificate provider, we don't try to update the type of Secret if it already exists. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Apr 10, 2024
…-io#6205) If a cluster used user-provided certificate and created a Secret named antrea-controller-tls of Opaque type, changing to use self-signed certificate would fail because the type field is immutable. To support switching the certificate provider, we don't try to update the type of Secret if it already exists. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
that referenced
this pull request
Apr 10, 2024
…#6206) If a cluster used user-provided certificate and created a Secret named antrea-controller-tls of Opaque type, changing to use self-signed certificate would fail because the type field is immutable. To support switching the certificate provider, we don't try to update the type of Secret if it already exists. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
that referenced
this pull request
Apr 10, 2024
…#6207) If a cluster used user-provided certificate and created a Secret named antrea-controller-tls of Opaque type, changing to use self-signed certificate would fail because the type field is immutable. To support switching the certificate provider, we don't try to update the type of Secret if it already exists. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
that referenced
this pull request
Apr 10, 2024
…#6208) If a cluster used user-provided certificate and created a Secret named antrea-controller-tls of Opaque type, changing to use self-signed certificate would fail because the type field is immutable. To support switching the certificate provider, we don't try to update the type of Secret if it already exists. Signed-off-by: Quan Tian <[email protected]>
tnqn
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cluster used user provided certificate and created a Secret named antrea-controller-tls of Opaque type, changing to use self-signed certificate would fail because the type field is immutable.
To support switching the certificate provider, we don't try to update the type of Secret if it already exists.
cert-manager has similar logic: cert-manager/cert-manager@7a4be1e
The following scenarios have been considered: