Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documents to replace AntreaProxy with Antrea Proxy #6515
Update documents to replace AntreaProxy with Antrea Proxy #6515
Changes from all commits
b1bc4a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worthy to check all
ProxyAll
and updateProxyAll
toproxyAll
if necessary.I can see there are inconsistent in some docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that every
ProxyAll (Without quotting)
is at the beginning of sentences. I don't think we need to update them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only when it refers to the
proxyAll
field in the YAML, we should we useproxyAll
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may not get what you mean. Do you mean that we should use
proxyAll
in the YAML comments, even if the word is at the beginning of sentences?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'proxyAll
here should refer to the
proxyAllfield in
antrea-agent.confright? In this case, we should use
proxyAllas Lan suggested, not
ProxyAll, as the field is named
proxyAll`. It does not matter whether it begins a sentence or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, got that. If so, how about this:
Option proxyAll
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current version here "Configuration
with
proxyAll
enabled is not verified" is fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant that how about changing the
ProxyAll tells antrea-agent .....
at the beginning of sentences in YAML files toOption proxyAll tells antrea-agent
.I didn't change this one where
proxyAll
is not at the beginning of sentences. @jianjunsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I think we can say "proxyAll tells..."