Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2 #6766

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Release 2.2 #6766

wants to merge 2 commits into from

Conversation

luolanzone
Copy link
Contributor

No description provided.

CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
@luolanzone luolanzone force-pushed the release-2.2-log branch 2 times, most recently from d4ce81c to e808f8f Compare October 25, 2024 03:12
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
- Refer to [this document](https://github.com/antrea-io/antrea/blob/release-2.2/docs/packetcapture-guide.md) for more information about this feature.
- Add a few new antctl sub-commands for `BGPPolicy` feature to improve usability:
- `antctl get bgppolicy` to get effective BGP policy applied on the Node. ([#6646](https://github.com/antrea-io/antrea/pull/6646), [@Atish-iaf])
- `antctl get bgppeers` to print current status of all BGP peers of effective BGP policy applied on the local Node. ([#6689](https://github.com/antrea-io/antrea/pull/6689) [#6755](https://github.com/antrea-io/antrea/pull/6755), [@Atish-iaf])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `antctl get bgppeers` to print current status of all BGP peers of effective BGP policy applied on the local Node. ([#6689](https://github.com/antrea-io/antrea/pull/6689) [#6755](https://github.com/antrea-io/antrea/pull/6755), [@Atish-iaf])
- `antctl get bgppeers` to print current status of all BGP peers of effective BGP policy applied on the local Node. ([#6689](https://github.com/antrea-io/antrea/pull/6689) [#6755](https://github.com/antrea-io/antrea/pull/6755), [@Atish-iaf])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the current status of all BGP peers of the effective BGPPolicy on the local Node". Or maybe we can remove "on the local Node" to make it shorter.

Copy link
Contributor Author

@luolanzone luolanzone Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, but keep on the local Node for all BGP command PRs to keep consistent.

CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
@antrea-io antrea-io deleted a comment from antoninbas Oct 28, 2024
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
- Refer to [this document](https://github.com/antrea-io/antrea/blob/release-2.2/docs/packetcapture-guide.md) for more information about this feature.
- Add a few new antctl sub-commands for `BGPPolicy` feature to improve usability:
- `antctl get bgppolicy` to get effective BGP policy applied on the Node. ([#6646](https://github.com/antrea-io/antrea/pull/6646), [@Atish-iaf])
- `antctl get bgppeers` to print current status of all BGP peers of effective BGP policy applied on the local Node. ([#6689](https://github.com/antrea-io/antrea/pull/6689) [#6755](https://github.com/antrea-io/antrea/pull/6755), [@Atish-iaf])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the current status of all BGP peers of the effective BGPPolicy on the local Node". Or maybe we can remove "on the local Node" to make it shorter.

CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
- Fix the template ID not existing error in IPFIX exporter for `FlowAggregator`. ([#6630](https://github.com/antrea-io/antrea/pull/6630), [@antoninbas])
- Fix an agent crash issue if the host interface is already attached to OVS bridge for `SecondaryNetwork`. ([#6666](https://github.com/antrea-io/antrea/pull/6666), [@xliuxu])
- Delay the initialization of ARP / NDP responders to fix the `ServiceExternalIP` feature when `SecondaryNetwork` is enabled. ([#6700](https://github.com/antrea-io/antrea/pull/6700), [@xliuxu])
- Fix a VM agent crash issue which is caused by a nil pointer exception of the config `SNATFullyRandomPorts`. ([#6748](https://github.com/antrea-io/antrea/pull/6748), [@wenyingd])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config -> config option

CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
- Run `IPPool` webhook handler when `SecondaryNetwork` is enabled. ([#6691](https://github.com/antrea-io/antrea/pull/6691), [@luolanzone])
- Fix slice init length issue for `NetworkPolicy` controller. ([#6715](https://github.com/antrea-io/antrea/pull/6715), [@cuishuang])
- Improve memory copying logic to avoid potential fault memory issue on Windows. ([#6664](https://github.com/antrea-io/antrea/pull/6664) [#6673](https://github.com/antrea-io/antrea/pull/6673), [@XinShuYang] [@tnqn])
- Resolve a Windows agent crash issue which is caused by a nil pointer exception of the config `egressSNATRandomFully`. ([#6668](https://github.com/antrea-io/antrea/pull/6668), [@XinShuYang])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config option

Could we move this one to be together with the SNATFullyRandomPorts nil pointer issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically because the feature itself was introduced in this release, we don't need to mention the 2 corresponding fixes in the release notes, it just creates noise

Support --random-fully for iptables SNAT / MASQUERADE rules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed two corresponding fixes in the release log.

CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
@antoninbas
Copy link
Contributor

@luolanzone this PR should have been opened against the release-2.2 branch, not main

@luolanzone
Copy link
Contributor Author

@luolanzone this PR should have been opened against the release-2.2 branch, not main

Hi @antoninbas the release-2.2 branch is not ready yet. I think @tnqn can help to create it once the PacketCapture PRs are merged.

@luolanzone
Copy link
Contributor Author

Hi @jianjuns @antoninbas @hongliangl , thanks for the review, I have addressed all comments, PTAL again.

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more minor comments from me

CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
- More robust system Tier creation / update for Antrea-native policies. ([#6696](https://github.com/antrea-io/antrea/pull/6696), [@antoninbas])
- Handle `ExternalIPPool` range changes in Egress controller. ([#6685](https://github.com/antrea-io/antrea/pull/6685), [@antoninbas])
- Close connection to IPFIX collector explicitly on Stop for `FlowAggregator`. ([#6635](https://github.com/antrea-io/antrea/pull/6635), [@antoninbas])
- Support `--random-fully` for iptables SNAT / MASQUERADE rules. ([#6602](https://github.com/antrea-io/antrea/pull/6602), [@antoninbas])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new feature, with a new configuration switch, so should be in Added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved

- Close connection to IPFIX collector explicitly on Stop for `FlowAggregator`. ([#6635](https://github.com/antrea-io/antrea/pull/6635), [@antoninbas])
- Support `--random-fully` for iptables SNAT / MASQUERADE rules. ([#6602](https://github.com/antrea-io/antrea/pull/6602), [@antoninbas])
- Unify the checker image and make it configurable when running `antctl check cluster`. ([#6579](https://github.com/antrea-io/antrea/pull/6579), [@tnqn])
- Update the `Finalizer` of `ResourceExport` to be domain-qualified strings. ([#6742](https://github.com/antrea-io/antrea/pull/6742), [@Dyanngg])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be a domain-qualified string

I think there is only one Finalizer in that case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated.

CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-2.2.md Outdated Show resolved Hide resolved
- Document a workaround for using `EgressSeparateSubnet` feature on OpenShift. ([#6622](https://github.com/antrea-io/antrea/pull/6622), [@luolanzone])
- Clean up stale resources when `antctl check cluster` failed. ([#6597](https://github.com/antrea-io/antrea/pull/6597), [@luolanzone])
- Fix hint annotation implementation in `AntreaProxy`. ([#6607](https://github.com/antrea-io/antrea/pull/6607), [@hongliangl])
- Add initialization of `creationTimestamp` when creating instances of `NodeLatencyStats` to fix a null `creationTimestamp` issue. ([#6574](https://github.com/antrea-io/antrea/pull/6574), [@hkiiita])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "to fix a ..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refined this sentence to the following:

Initialize `creationTimestamp` when creating instances of `NodeLatencyStats` to prevent a null `creationTimestamp` issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants