[LatencyMonitor] Decouple sending of ICMP probes and latency reporting

[faheem047]

Fixes #6570

Separated the process of sending probes and reporting the latency to the response of send probes

Reporting frequency handled by a conditional block where minimum report interval is set to 10s with added jitter to avoid synchronization

I sincerely seek your guidance in resolving this issue and would greatly value your feedback and insights on the proposed changes.

[antoninbas]

thanks for your PR
please refer to the appropriate issue in the commit message and PR description using Fixes #<issue number>

[antoninbas]

define a top-level constant for the minimum reporting interval

[faheem047]

I have done the needful changes as asked well your review required in this regard

[antoninbas]

The code changes look good to me, and I have approved running the github workflows for the PR. Some changes to unit tests may be required. Did you run the unit tests for this package locally?

[antoninbas]

The code changes look good to me, and I have approved running the github workflows for the PR. Some changes to unit tests may be required. Did you run the unit tests for this package locally?

Confirmed that unit tests are failing in CI

[faheem047]

The code changes look good to me, and I have approved running the github workflows for the PR. Some changes to unit tests may be required. Did you run the unit tests for this package locally?

Confirmed that unit tests are failing in CI

Greetings,
Let me review the unit tests and make the necessary changes accordingly.
P.S. I might need some guidance along the way.
If possible, I will also run the tests locally to verify.

[faheem047]

@antoninbas could you please guide me along what changes i have to do in monitor_test.go file in accordance to changes i have made in monitor.go a little refrerence would be helpful

[antoninbas]

@antoninbas could you please guide me along what changes i have to do in monitor_test.go file in accordance to changes i have made in monitor.go a little refrerence would be helpful

The first step is to run go test ./pkg/agent/monitortool locally and look for which unit tests are failing. Then you need to update the tests accordingly to account for your changes. These unit tests use a "fake clock" to simulate the passing of time. You will need to change how the fake clock advances and maybe add a few assertions to validate things. I suggest reading the code for the failing tests before making any change, to make sure you understand the flow of the test and the existing assertions.

[antoninbas]

please leave a comment when you are ready and you want to request a review for us (or use the Github request review functionality).

[antoninbas]

It's bad practice to check in a binary file to source control

It's great if you want to use act locally (even though you should not need it for this change), but please do not check in the act folder.