Skip TestFQDNCacheMinTTL if cluster has Windows Nodes. Fixes #6891 #6918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestFQDNCacheMinTTL e2e test currently does not support Windows. We skip it if any Node in the test cluster is a Windows Node, which is also consistent with other AntreaPolicy e2e tests.
devc007
changed the title
devc007
changed the title
antoninbas
reviewed
Jan 10, 2025
| skipIfIPv6Cluster(t) | ||
| skipIfNotRequired(t, "mode-irrelevant") | ||
|
|
||
|
|
There was a problem hiding this comment.
is this line not empty?
| skipIfIPv6Cluster(t) | ||
| skipIfNotRequired(t, "mode-irrelevant") | ||
|
|
||
|
|
There was a problem hiding this comment.
remove extra empty line
|
@antoninbas Could you please close #6913? I'll create a fresh PR instead, as I'm not entirely sure how to make a commit in the existing one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestFQDNCacheMinTTL e2e test currently does not support Windows. We skip it if any Node in the test cluster is a Windows Node, which is also consistent with other AntreaPolicy e2e tests.
As @antoninbas suggested, I have relocated the skipX condition to the beginning of TestFQDNCacheMinTTL. Now, the skip condition will execute before any subset of TestFQDNCacheMinTTL, making testWithFQDNCacheMinTTL shorter and possibly more efficient.