Skip to content

Commit

Permalink
Stop deleting group entries on switch connection (#75)
Browse files Browse the repository at this point in the history
There is no reason to treat groups any differently from flows, meters, etc.

Bump up version to v0.12.0.

Signed-off-by: Antonin Bas <[email protected]>
  • Loading branch information
antoninbas authored Oct 26, 2023
1 parent 0149b74 commit a73fa6b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v0.11.0
v0.12.0
9 changes: 0 additions & 9 deletions ofctrl/fgraphSwitch.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,3 @@ func (self *OFSwitch) NewFlood() (*Flood, error) {

return flood, nil
}

// clearGroups clears all existing groups.
func (self *OFSwitch) clearGroups() error {
groupMod := openflow15.NewGroupMod()
groupMod.GroupId = openflow15.OFPG_ALL
groupMod.Command = openflow15.OFPGC_DELETE
groupMod.Type = openflow15.GT_ALL
return self.Send(groupMod)
}
3 changes: 0 additions & 3 deletions ofctrl/ofSwitch.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,6 @@ func (self *OFSwitch) IsReady() bool {

// Handle switch connected event
func (self *OFSwitch) switchConnected() error {
if err := self.clearGroups(); err != nil {
return fmt.Errorf("fails to clear groups: %v", err)
}
// Main receive loop for the switch
go self.receive()
// Periodically sends echo request message on the connection.
Expand Down

0 comments on commit a73fa6b

Please sign in to comment.